docs(ward-flow): Command mockup and design system, third edition - #2738
docs(ward-flow): Command mockup and design system, third edition#2738BigSimmo wants to merge 20 commits into
Conversation
…ckpoint) Checkpoint of the merged third edition: the Live edition Command content, behaviour and engine re-skinned with the Platinum Raised Cool identity and material, the design system page and document that carry it, and the merge brief and verification harness. The review fix pass is still in progress and the owner's universal header and rail are not yet grafted in, so this commit records progress rather than the finished build. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013eS6SCvB97KyHMCQWpzvzv
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_18d60aad-cbfb-49e6-a3e7-6dbe4fafc656) |
CI triageCI failed on this PR. Automated classification of the 3 failed job(s):
Compared with main CI run #16407 (failure). That run's conclusion is an aggregate and did not exercise Classification is evidence routing, not permission to ignore a failure. Exact quarantined Playwright identities remain governed by the flake ledger. |
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013eS6SCvB97KyHMCQWpzvzv
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4b96c56b0e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…cts honest Three findings from review, all confirmed by running the harness. The font fixtures the route handlers read were never committed, so readFileSync threw inside the handler and neither audit could complete from a fresh checkout. Fixtures now resolve beside the script rather than from the caller's working directory, a missing fixture falls back to the live stylesheet instead of throwing, and the run says which mode it used. The latin subset of the stylesheet and the three variable fonts it names are committed, so a run is offline and repeatable; all three families are SIL OFL and their provenance is recorded. The reconcile assertion required window.__commandCheck of every page. The design system does not define it, so the two-artifact run the brief advertises could never pass. It is now gated on the page being Command, where it stays strict. The diagram height check had the same defect and is gated the same way. The type floor tested only minFont and merely printed minSvg, so a diagram label below 10.5px still reported PASS. The verdict now covers both, which is the HTML-or-SVG guarantee the design system states. Verified by running the harness from the repository root: both command-third-edition.html and design-system-third-edition.html report ALL GREEN with fonts stubbed locally. The type floor was mutation tested by forcing svg text to 9px, which now reports "FAIL typefloor min 10.5px html, 9px svg" and previously passed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0142trjgjRAP2GA9wzqoYUAE
Saves everything produced before the session's usage limit stopped the agents: the mockup with the partial fix pass applied, the design system page and document, the 82 review findings, the harness output at wind down, the owner's rail and build sheet artifacts, the build sheet specification, the rail map with the integration plan, a first draft of the restyled shell rules, and HANDOVER.md, which says exactly what is done, what is not, and how the next session continues. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013eS6SCvB97KyHMCQWpzvzv
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013eS6SCvB97KyHMCQWpzvzv
…c' into claude/review-four-mockups-0l9x8c
The handover checkpoint added HANDOVER.md and inputs/SHELL-SPEC.md, which cite five paths that do not resolve on this branch, and docs:check-links failed static-pr on the merge head. None of the five is a mistake to repoint. SHELL-SPEC.md is the numbered inventory of the artifacts this kit was built from, each with its published artifact URL: design-standard.html, header.html and rail.html live on the working line the owner published the shell from, and command-premium.html is on claude/hospital-mockup-premium-qzq6cx via PR #2737. Repointing those citations at files on this branch would misattribute where each rule was extracted from. HANDOVER.md's SHELL-REVIEW.md row says in its own text "Not written. The review agent was cut off. Do it first", so it is a work item that resolves when that step is done. Both go in the scoped allowlist with their reasons, which is what that mechanism is for and matches the existing ward-flow entries. The documents are left byte-for-byte as the handover wrote them. Verified: docs link check passed, 7405 repo path references resolve. Both artifacts still report ALL GREEN through the kit's own harness. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0142trjgjRAP2GA9wzqoYUAE
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_a7a88ade-3267-4038-b120-754535c8ff38) |
The wind-down checkpoint and this branch's own fixes added documentation files (the handover kit's HANDOVER.md, its inputs and shell notes, and the font fixtures' README), so check:repo-awareness-snapshot failed static-pr with "documentation differs from the repository". Regenerated with npm run snapshot:repo-awareness. Five added entries, no other change. Verified: check:repo-awareness-snapshot reports in step, 223 pages, 911 documents, 2718 reviews. docs link check still passes with 7405 references resolving. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0142trjgjRAP2GA9wzqoYUAE
|
Standing down on the remaining CI failure: it is not this PR's, and the fix belongs on The two static failures on this branch are fixed and Why it is not this PR's. The diff against Root cause, which is on --danger: Mark; /* line 4742 on origin/main — identical */
--danger-soft: Canvas;
Every sibling status tone in that same block already uses a text colour, which is why only --info: LinkText;
--success: CanvasText;
--warning: CanvasText;
--danger: Mark; /* the odd one out */The block's own comment states the pairing rule it is breaking — Proposed patch, one line, leaving the solid-fill tokens alone: - --danger: Mark;
+ --danger: CanvasText;Why it surfaces here and not on every PR. The violation only appears when an excluded catalogue entry actually renders in the first viewport of I have not applied the patch here. This is a docs-only PR, and a change to the shared forced-colors design tokens affects every status surface in the app and needs its own browser proof rather than riding a documentation change. Raising it for a separate fix instead. Generated by Claude Code |
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013eS6SCvB97KyHMCQWpzvzv
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_63088860-58fa-4f12-853f-73be24887fbd) |
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013eS6SCvB97KyHMCQWpzvzv
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013eS6SCvB97KyHMCQWpzvzv
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013eS6SCvB97KyHMCQWpzvzv
…ository paths Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013eS6SCvB97KyHMCQWpzvzv
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013eS6SCvB97KyHMCQWpzvzv
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013eS6SCvB97KyHMCQWpzvzv
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013eS6SCvB97KyHMCQWpzvzv
Applies the remaining review findings to the Command mockup and the design system page (64 applied, 5 rejected with reasons recorded in the standard), regenerates the Markdown standard from the page, and re-proves both files with the kit harness in both themes (ALL GREEN). Cites the uncommitted screenshot folder by a non-path name so the docs link check holds on a fresh checkout, and restores scripts/check-docs-links.mjs to main now that every citation resolves without an allowlist. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013eS6SCvB97KyHMCQWpzvzv
…ion, graft-ready The owner's header and rail as third edition fragments: the shell stylesheet and the design system extras, the markup, the script with the engine facade it expects, a standalone preview with its stub and probes, and the graft notes for the next builder. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013eS6SCvB97KyHMCQWpzvzv
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013eS6SCvB97KyHMCQWpzvzv
… name in the shell notes Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013eS6SCvB97KyHMCQWpzvzv
Summary
docs/ward-flow/mockups/command-third-edition.html, the Ward Flow Command mockup, third edition: the Live edition's content, behaviour, engine, data and layout (masthead figures, route words, one bar stepper, fills only on eligible or recorded wards, grouped rail with derived counts and a reconciliation line, Light Dark Auto appearance control, 10.5 px floor on a seven step scale) re-skinned with the Platinum Raised Cool identity and material (platinum neutrals with a fall of light, deep slate accent, brass as a bar and never a fill, Source Serif 4, Source Sans 3 and JetBrains Mono, alpha hairlines, one elevation step). Light and dark.docs/ward-flow/mockups/design-system-third-edition.htmlanddocs/ward-flow/mockups/WARD-FLOW-DESIGN-SYSTEM.md, the design system that every Ward Flow mockup is built to: the ten rules, the tokens with live swatches and recomputed contrast pairs, the three faces and the scale, the material, the components rendered live from the same stylesheet, behaviour, wording, the accessibility floor, the definition of done with the verification harness, the recipe for a new mockup, the departures from the Board language and from the first and second editions, and the adoption plan for the eighteen mockups.docs/ward-flow/mockups/third-edition-kit/: the merge brief that governed the build, and the headless Chromium harness (check.mjs,shots.mjs) that proves a build in both themes.Verification
npm run verify:pr-local -- --files <the six files>with its summary pasted here, Prettier on the committed files, and the harness output (node docs/ward-flow/mockups/third-edition-kit/check.mjs <file> platinum, ALL GREEN in both themes) for the mockup and the design system page.verify:uicoverssrc/routes; these are standalone reference documents underdocs/, not routes, and nothing undersrc/changed.verify:release, retrieval evals, production and deployment readiness: not applicable, no executable product scope.Risk and rollout
Clinical Governance Preflight
Not in scope (no ingestion, answer generation, search, source rendering, document access, privacy or clinical output change). The mockup keeps every synthetic data disclosure the prototype carried: the "Synthetic prototype" mark in the masthead, the foot note that every figure is invented and only the site and health service names are real, and the reconciliation line the page derives on every load.
Notes
docs/ward-flow/mockups/do; nothing undersrc/gains a third party font request.🤖 Generated with Claude Code
https://claude.ai/code/session_013eS6SCvB97KyHMCQWpzvzv
Generated by Claude Code
Note
Low Risk
Documentation and offline HTML mockups only; no executable product, auth, or data-path changes.
Overview
This PR lands the Ward Flow third edition as documentation and standalone mockups only: no changes under
src/, routes, dependencies, or deployment.It introduces the frozen design standard (
WARD-FLOW-DESIGN-SYSTEM.mdplus the livedesign-system-third-edition.htmlpage), merging Live edition behaviour with Platinum Raised Cool visual identity (tokens, ten rules, components, contrast table, adoption plan for eighteen mockups). The Command reference mockup (command-third-edition.html) re-skins the existing Live engine and synthetic data with that standard.A
third-edition-kitadds merge brief, shell/rail inputs, and headless Chromiumcheck.mjs/shots.mjsharnesses;.gitignorenow excludes regenerated proof screenshots underthird-edition-shots/.data/repo-awareness-snapshot.jsonregisters the new doc paths and bumps snapshot metadata.The PR description notes this may be a checkpoint before universal header/rail graft and full harness output on the final head.
Reviewed by Cursor Bugbot for commit 6f19733. Configure here.