[BenCodez]

Move the handshake regression tests under com.bencodez.votifierplus.tests and document the convention for future tests. A test-only accessor invokes the existing parser without changing production visibility.

Validation: clean package build; all 145 tests passed; fresh shaded JAR contains no test classes; independent read-only review found no actionable issues.

Summary by CodeRabbit

• Tests

  • Added coverage confirming that handshake parsing handles CRLF, LF, and bare CR line endings without consuming following data, and still rejects oversized handshakes.
  • Reorganized the handshake tests under the established test namespace.

• Documentation

  • Clarified test organization guidelines, including package structure, preserving test assertions and discovery, and validating package changes.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: a89978a1-7b98-4db2-9ac6-cf072e2e8a67

📥 Commits

Reviewing files that changed from the base of the PR and between 74bd9d4 and 4eb4f60.

📒 Files selected for processing: 3

• AGENTS.md
• VotifierPlus/src/test/java/com/bencodez/votifierplus/tests/net/VoteForwarderHandshakeTest.java
• VotifierPlus/src/test/java/com/vexsoftware/votifier/net/VoteForwarderHandshakeTest.java

💤 Files with no reviewable changes: 1

• VotifierPlus/src/test/java/com/vexsoftware/votifier/net/VoteForwarderHandshakeTest.java

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details

⏰ Context from checks skipped due to timeout: 1

• GitHub Check: build

🧰 Additional context used

🧠 Learnings: 1

📓 Common learnings

Learnt from: CR
Repo: BenCodez/VotifierPlus

Timestamp: 2026-10-16T18:19:04.498Z
Learning: Source excerpt:
# Maintainer and AI-agent guide

## Change and PR workflow

Before any commit, push, PR update, review reply, or other remote change, run focused protocol/security tests, the full package build, fresh-artifact inspection, and the applicable `git diff --check`. For PR and branch work, inspect the complete base-to-HEAD diff. For standalone commit reviews, inspect the requested commit against its first parent (or the explicitly requested range) instead of substituting a base-to-HEAD branch diff. Before committing local work, also inspect the staged changes and every relevant intended unstaged or untracked change as one effective final patch.

Learnt from: CR
Repo: BenCodez/VotifierPlus

Timestamp: 2026-10-16T18:19:04.498Z
Learning: Source excerpt:
# Maintainer and AI-agent guide

## Build and verification

Confirm current CI/POM settings. Use `package`, not developer/install profiles that copy artifacts to a server. Verify the fresh shaded JAR, actual test discovery, and `git diff --check`.

📝 Walkthrough

The handshake test moved to the com.bencodez.votifierplus.tests namespace. The tests retain checks for CRLF, LF, and bare CR terminators, following payload data, and rejection of oversized handshakes. AGENTS.md now documents test package organization rules.

Changes: Test namespace reorganization

Layer / File(s)	Summary
Relocate handshake tests and preserve coverage AGENTS.md, VotifierPlus/src/test/java/com/vexsoftware/votifier/net/VoteForwarderHandshakeTest.java, VotifierPlus/src/test/java/com/bencodez/votifierplus/tests/net/VoteForwarderHandshakeTest.java	AGENTS.md now specifies test namespace and package-directory rules. The handshake test was removed from its old package and added under the required namespace. It checks line terminators, payload preservation, and oversized handshakes.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 4eb4f

The handshake regression tests remain discoverable after relocation. No merge-blocking issue was identified.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 1 files. (1 skipped: 1…	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 4 passed

Check name	Status	Explanation
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly and concisely describes the main change: moving the handshake regression test to the standardized test package.

Full details: Docstring Coverage

Explanation

Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 1 files. (1 skipped: 1 unsupported.)

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

• Fix all pre-merge checks with AI

✨ Finishing Touches: 💡 1

📝 Generate docstrings: 💡

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-16T19:06:25.236002Z	4eb4f60	Draft marked ready
🔒 Security Review	✅ Completed 2026-10-16T19:07:28.959484Z	4eb4f60	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.