Reduce unnecessary Maven repository lookups - #166
Merged
Conversation
|
You have reached your Codex usage limits for security reviews. Please try again later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
velocity-api:3.4.0resolves from Papervelocity-brigadier:1.0.0-SNAPSHOTtransitive dependency from the Velocity API dependency and annotation-processor pathWhy
Jenkins build 846, triggered by SimpleAPI build 231, resolved the Spigot
1.21.9-R0.1-SNAPSHOTmetadata successfully from Spigot and Paper, then stalled while Maven waited for the same snapshot metadata from unrelated repositories.This is the same unnecessary cross-repository metadata lookup pattern fixed in BenCodez/VotingPlugin#1555. VotifierPlus uses the released
com.bencodez:simpleapi:1.0, so BenCodez snapshot resolution is not required here.A first CI run confirmed that Maven no longer hung on Spigot snapshot metadata, but the Velocity Nexus then timed out while resolving
velocity-api:3.4.0. Paper serves that exact release. After removing Velocity Nexus, Maven exposed its optionalvelocity-brigadiersnapshot; VotifierPlus only uses Velocity's simple command API and does not reference Brigadier, so the same exclusion already used by VotingPlugin is applied here.Validation
pom.xmlparses as well-formed XMLsimpleapi:1.0: available from BenCodez Nexusbungeecord-api:1.21-R0.4: available from Maven Centralvelocity-api:3.4.0: available from Papermvn -B -f VotifierPlus/pom.xml package: passed in 38 seconds