Skip to content

Add explicit JavaScript security finding regression tests - #311

Merged
BenCodez merged 5 commits into
masterfrom
test/javascript-security-regressions
Sep 7, 2026
Merged

BenCodez merged 5 commits into
masterfrom
test/javascript-security-regressions

Conversation

@BenCodez

@BenCodez BenCodez commented Sep 7, 2026

Copy link
Copy Markdown
Owner

Summary

  • add named regression coverage for display-name placeholder injection
  • add named regression coverage for PlaceholderAPI-generated JavaScript markers
  • add named regression coverage for conditional-item placeholder injection
  • verify all generated markers remain inert text under the boundary-first implementation merged in Secure authored JavaScript text segments #303

Testing

  • /tmp/apache-maven-3.9.11/bin/mvn -q -Dmaven.repo.local=/tmp/m2-advancedcore -Dtest=JavascriptSecurityFindingRegressionTest test
  • git diff --check

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 7, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-07T23:03:34.434356Z d645262 New commits
🔒 Security Review Completed 2026-09-07T21:27:14.802626Z a4163e6 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a4163e627b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 694f5ea84e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

BenCodez commented Sep 7, 2026

Copy link
Copy Markdown
Owner Author

Reworked the regression tests to execute the real PlaceholderAPI/display-name, PlaceholderUtils, and ItemBuilder paths. Full mvn clean package passes. @codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Swish!

Reviewed commit: 8aab62047b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@BenCodez
BenCodez merged commit 6dccb35 into master Sep 7, 2026
4 checks passed
@BenCodez
BenCodez deleted the test/javascript-security-regressions branch September 7, 2026 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant