Repository navigation
Sort ports in the TreeNodesModel XML (#851) - #1260
Merged
Merged
Conversation
PortsList is an unordered_map, so writeTreeNodesModelXML() emitted the ports in hash order, which differs across builds and shows up in Groot2. Sort them by direction (input, output, inout), then by name, as was done before d5ea17b. Keeping the order of providedPorts() would need to change the PortsList type (#870), which breaks API/ABI; this is the compatible subset. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
facontidavide
force-pushed
the
fix/model-xml-port-order
branch
from
October 26, 2026 06:36
6ed3dbe to
c1a7ce9
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the visible part of #851.
PortsListis anunordered_map, sowriteTreeNodesModelXML()emitted ports in hash order: it can change from build to build, and Groot2 shows it as is. This restores the sorting removed in d5ea17b: input, then output, then inout ports, alphabetical within each group.Keeping the exact declaration order of
providedPorts()needsPortsListto become an ordered container, which breaks API/ABI (#870). This PR is the subset that stays compatible: one .cpp file, no header changes.Test:
BehaviorTreeFactory.ModelPortsAreSortedfails on master and passes with the fix. 596/596 tests pass locally.🤖 Generated with Claude Code