Playground: correct excludeFromAutomaticTesting reasons for texture-format, GPU-particle, and remote-asset tests#1779
Open
bkaradzic-microsoft wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the human-readable reason strings for a set of already-excluded Playground automated tests so the stated failure cause matches the actual pre-render exceptions seen on Babylon Native, avoiding misdirected triage toward pixel-diff/rendering parity work.
Changes:
- Updated
reasonmessages for texture-format-related failures to reflectUnsupported texture format or typethrows. - Updated
reasonmessages for many GPU particle tests to reflect pre-render exceptions (e.g.,ARRAY_BUFFERaccess), plus specific cubemap/Image-constructor failures.
| "playgroundId": "#D7LQAZ#0", | ||
| "excludeFromAutomaticTesting": true, | ||
| "reason": "Pixel comparison fails (more than 20% pixels differ)", | ||
| "reason": "Native cubemap load gap: throws 'Cannot load cubemap because 6 files were not defined' before rendering (not a pixel-diff).", |
Member
Author
There was a problem hiding this comment.
Done in 2dfbe85 — reused the existing Cubemap load not implemented on Babylon Native convention wording (matches config.json line 687), with the verbatim Cannot load cubemap because 6 files were not defined appended for the specific trigger.
| "playgroundId": "#SGAEHS#0", | ||
| "excludeFromAutomaticTesting": true, | ||
| "reason": "Pixel comparison fails (more than 20% pixels differ)", | ||
| "reason": "Native lacks the 'Image' DOM constructor: throws 'ReferenceError: Image is not defined' before rendering (not a pixel-diff).", |
Member
Author
There was a problem hiding this comment.
Done in 2dfbe85 — reason now carries the verbatim ReferenceError: 'Image' is not defined (quotes preserved).
| "playgroundId": "#3HLS3D#2", | ||
| "excludeFromAutomaticTesting": true, | ||
| "reason": "Pixel comparison fails (more than 20% pixels differ)", | ||
| "reason": "GPUParticleSystem throws TypeError 'Unable to get property ARRAY_BUFFER of undefined' on Native before rendering (not a pixel-diff).", |
Member
Author
There was a problem hiding this comment.
Done in 2dfbe85 — all 34 GPU-particle reasons now use the verbatim exception text: TypeError: Unable to get property 'ARRAY_BUFFER' of undefined or null reference.
bkaradzic-microsoft
force-pushed
the
fix-config-exclude-reasons
branch
from
85bfbb0 to
2dfbe85
Compare
…at, GPU-particle, remote-asset tests) Replace stale/generic exclude reasons with the verbatim runtime error each test actually hits on Babylon Native, re-verified on a fresh master build: - Texture-format tests (BabylonJS#1609 family): RuntimeError: Unsupported texture format or type ... instead of a pixel-diff label. - GPU-particle tests: the verbatim TypeError/ReferenceError thrown before rendering (ARRAY_BUFFER, 'Image'), and reuse of the existing 'Cubemap load not implemented on Babylon Native' convention. - Remote-asset / misc tests: several were mislabeled as generic pixel-diff or crash; use the actual thrown error (Unable to load ... Unknown error opening URL for curl-reachable URLs, createObjectURL missing, OBJ 'Out of stack space', cubemap load gap), or the measured pixel-diff. Reason-string wording only; no test is enabled or disabled. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
bkaradzic-microsoft
force-pushed
the
fix-config-exclude-reasons
branch
from
2dfbe85 to
7825a2b
Compare
bkaradzic-microsoft
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
51 excluded tests carry a generic/stale reason (mostly "Pixel comparison fails (more than 20% pixels differ)", a few "Test crashes or hangs" / "Loading remote https:// assets is not supported"), but they actually throw before ever reaching pixel comparison, or fail for a different reason than labelled. This corrects the
reasonstrings to the real, verified failure so triage isn't misdirected toward rendering-parity work.No tests are enabled/disabled — only the human-readable
reasonstrings change (51 lines, JSON otherwise untouched).Corrections
Each affected index was run individually headless (
--include-excluded --test-index=N) on Playground Debug (D3D11, Chakra) atmasterand the thrown error captured.Texture-format + GPU-particle (39)
Textured - Area Lights - Standard Material,… - PBRRuntimeError: Unsupported texture format or type: format 5, type 3553Normed 16 bits texture formatsRuntimeError: Unsupported texture format or type: format 33322, type 5GPU Particles - *TypeError: Unable to get property 'ARRAY_BUFFER' of undefined or null referenceGPU Particles - Multiply BlendCubemap load not implemented on Babylon Nativeconvention (Cannot load cubemap because 6 files were not defined)GPU Particles - FlowmapsReferenceError: 'Image' is not definedRemote-asset + misc (12)
Re-verified on a fresh
masterbuild with network egress (the referenced CDN assets return HTTP 200 viacurl, so these are not dead-asset / offline-CI failures):Gaussian Splatting modifyUncaught Error: Invalid argumentGaussian Splatting SPZ SHRuntimeError: Unable to load from https://raw.githubusercontent.com/.../hornedlizard.spz: Unknown error opening URLSPZ v3 - SplatRuntimeError: Unable to load from https://assets.babylonjs.com/splats/combined_SPZv3.spz: Unknown error opening URLEXT_lights_iesRuntimeError: Unable to load from …/Example.gltf: 'name' is not definedCSGVertColorError: Unknown error opening URL(remote asset reachable via curl)Chibi RexCannot load cubemap because 6 files were not definedYetiCSGError: Unknown error opening URL(remote asset reachable via curl)GLTF Buggy with Meshopt CompressionObject doesn't support property or method 'createObjectURL'GlowLayerPrepass SSAO + glow layerFrameGraph nrge depth of fieldOut of stack space(OBJ parser recursion)Notably, the four
Unknown error opening URLcases (100/104/157/188) load URLs thatcurlfetches at HTTP 200 — a genuine BN HTTPS/URL-open issue, not a network or dead-asset problem.Testing
config.jsonre-validated as JSON; test count unchanged (720).reasonlines.