feat(ui): relocate plugin web pages from sidebar to dedicated dashboard panel - #9823
Open
XTsat wants to merge 7 commits into
Open
feat(ui): relocate plugin web pages from sidebar to dedicated dashboard panel#9823XTsat wants to merge 7 commits into
XTsat wants to merge 7 commits into
Conversation
Contributor
There was a problem hiding this comment.
Hey - I've found 2 issues
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="dashboard/src/router/MainRoutes.ts" line_range="93-97" />
<code_context>
props: { initialTab: 'market' },
meta: { extensionTab: 'installed', pluginView: 'market' }
},
+ {
+ name: 'ExtensionPluginPages',
+ path: 'pages/:pluginName?/:pageName?',
+ component: () => import('@/views/ExtensionPage.vue'),
+ props: { initialTab: 'installed' },
+ meta: { extensionTab: 'pluginPages', pluginView: 'pluginPages' }
+ },
{
name: 'ExtensionMcp',
</code_context>
<issue_to_address>
**issue (broader_impact):** Existing bookmarks, external links, or plugin-generated links to `/plugin-page/:pluginName/:pageName` now resolve to a 404 because the old route is deleted and no redirect to `ExtensionPluginPages` is registered.
**Triggers:** When a user opens a previously generated or bookmarked standalone plugin-page URL.
**Suggested fix:** Keep a compatibility redirect for `/plugin-page/:pluginName/:pageName` to `ExtensionPluginPages` with the corresponding parameters.
</issue_to_address>
### Comment 2
<location path="dashboard/src/views/ExtensionPage.vue" line_range="192-194" />
<code_context>
+// All installed plugins that ship web pages, listed in the page switcher row.
+const pluginsWithPages = computed(() =>
+ filteredExtensions.value.filter(
+ (plugin) => Array.isArray(plugin?.pages) && plugin.pages.length > 0,
+ ),
+);
+
+const openPluginPage = (plugin) => {
</code_context>
<issue_to_address>
**issue (bug_risk):** The plugin-page switcher includes installed plugins with pages regardless of `plugin.activated`; selecting a disabled plugin navigates to its page and `PluginPagePage` then displays a disabled-plugin error instead of excluding it from the switcher.
**Triggers:** When an installed plugin exposes pages but is disabled.
**Suggested fix:** Filter the switcher list to activated plugins, or disable the corresponding switcher buttons and prevent navigation.
```suggestion
filteredExtensions.value.filter(
(plugin) =>
plugin?.activated &&
Array.isArray(plugin?.pages) &&
plugin.pages.length > 0,
),
```
</issue_to_address>Sourcery assessment
Approval pending. 2 findings to address first.
Blocking findings: dashboard/src/router/MainRoutes.ts:97, dashboard/src/views/ExtensionPage.vue:194
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
Author
|
针对插件页面的修改已经完成了,可以审阅了 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
让插件UI页面更符合面板使用 #9816
Modifications / 改动点
将 Astrbot 的插件 Web 面板从侧边栏中独立出来,新建一个“插件页面”页面
Screenshots or Test Results / 运行截图或测试结果
PixPin_2026-08-26_18-52-30.mp4
Checklist / 检查清单
😊 If there are new features added in the PR, I have discussed it with the authors through issues/emails, etc.
/ 如果 PR 中有新加入的功能,已经通过 Issue / 邮件等方式和作者讨论过。
👀 My changes have been well-tested, and "Verification Steps" and "Screenshots" have been provided above.
/ 我的更改经过了良好的测试,并已在上方提供了“验证步骤”和“运行截图”。
🤓 I have ensured that no new dependencies are introduced, OR if new dependencies are introduced, they have been added to the appropriate locations in
requirements.txtandpyproject.toml./ 我确保没有引入新依赖库,或者引入了新依赖库的同时将其添加到
requirements.txt和pyproject.toml文件相应位置。😮 My changes do not introduce malicious code.
/ 我的更改没有引入恶意代码。
Summary by Sourcery
Move plugin web interfaces into a dedicated, integrated dashboard page with improved navigation and plugin management.
New Features:
Bug Fixes:
Enhancements:
Chores: