Fix patch_to to handle Enum and non-type iterables correctly#826
Merged
Conversation
Contributor
|
Thank you :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
patch_tousestuplify(cls)to iterate over the target class(es), buttuplifyiterates overEnummembers (and other iterables) rather than treating them as a single class, causing unexpected behaviour when patching Enum subclasses.Fix
Check if
clsis a plaintypefirst and wrap it in a tuple directly, falling back totuplifyonly for sequences of classes. This ensures Enum classes (and any other iterable types) are treated as a single patch target.Also fixes an unrelated CI failure: matplotlib 3.11 detaches a figure's canvas on
plt.close, breakingtest_fig_existswhen run via nbdev's inline backend. It now re-attaches an Agg canvas if needed.Changes
fastcore/basics.py: Replace baretuplify(cls)with(cls,) if isinstance(cls, type) else tuplify(cls)inpatch_tofastcore/test.py/nbs/00_test.ipynb: Maketest_fig_existsre-attach aFigureCanvasAggwhen the figure's canvas has been detached (matplotlib >= 3.11)