Fix throw render() history nav - #96
Merged
Merged
Conversation
dajinchu
commented
Aug 5, 2026
| } | ||
| // Initially, currentVisit was just created by historyPoppedToLocationWithRestorationIdentifier | ||
| // If abort rendering, we'd rather Vike pass _turbolinksVisit, but it does not, so we recover from Turbolinks global | ||
| // There is risk of race condition if a history nav and a regular nav happen at the same time. |
Collaborator
Author
There was a problem hiding this comment.
This solution remains imperfect. We need to open a Vike feature request. onBeforeRoute is a bit of a hack in general.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When making a history navigation to a route that calls
throw render()we callhistoryPoppedToLocationWithRestorationIdentifiertwice, once on the original visit and again on each abort-render. This triggers twoturbolinks:visitevents and causes multiple Visits to be created, rather than updatingredirectedToLocationon the existing Visit. This breaks Turbolinks invariant which may lead to bugs on the mobile app and race conditions.