Skip to content

fix: syntax error#2096

Merged
RohitKushvaha01 merged 1 commit intoAcode-Foundation:ajit/fix-fetch-auth-configfrom
RohitKushvaha01:ajit/fix-fetch-auth-config
May 10, 2026
Merged

fix: syntax error#2096
RohitKushvaha01 merged 1 commit intoAcode-Foundation:ajit/fix-fetch-auth-configfrom
RohitKushvaha01:ajit/fix-fetch-auth-config

Conversation

@RohitKushvaha01
Copy link
Copy Markdown
Member

No description provided.

@RohitKushvaha01 RohitKushvaha01 merged commit 01dfe2a into Acode-Foundation:ajit/fix-fetch-auth-config May 10, 2026
4 of 5 checks passed
@RohitKushvaha01 RohitKushvaha01 deleted the ajit/fix-fetch-auth-config branch May 10, 2026 13:44
@RohitKushvaha01 RohitKushvaha01 restored the ajit/fix-fetch-auth-config branch May 10, 2026 13:44
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 10, 2026

Greptile Summary

This PR replaces the system.getInstaller(success, error) call in config.js with an equivalent direct cordova.exec(success, error, 'System', 'getInstaller', []) call to resolve a reference error on the base branch where system was not in scope.

  • The functional behavior is unchanged: config.IAP_AVAILABLE is still set via the same native Cordova action (System/getInstaller), with an identical success and error handler.
  • The change bypasses the system Cordova plugin wrapper (defined in src/plugins/system/www/plugin.js) in favour of hardcoded service/action strings, making the call harder to trace back to the plugin.
  • The success callback body retains two-tab indentation from the prior layout, leaving it over-indented by one level relative to the new cordova.exec( call site.

Confidence Score: 4/5

Safe to merge — the change is functionally identical to the code it replaces.

The only differences from the original are cosmetic (indentation) and a loss of abstraction (hardcoded Cordova service/action strings instead of the system plugin wrapper). No logic, data flow, or error handling was altered.

src/lib/config.js — worth a second look on the indentation and the direct cordova.exec call vs the plugin wrapper.

Important Files Changed

Filename Overview
src/lib/config.js Replaces system.getInstaller() wrapper with a direct cordova.exec() call — functionally equivalent but bypasses the plugin abstraction and introduces inconsistent indentation in the callback body.

Reviews (1): Last reviewed commit: "fix: syntax error" | Re-trigger Greptile

Comment thread src/lib/config.js
Comment on lines 55 to +65
@@ -62,7 +62,6 @@ system.getInstaller(
(error) => {
console.error(error);
config.IAP_AVAILABLE = typeof iap !== "undefined";
},
);
}, 'System', 'getInstaller', []);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 The success callback body is still indented at two tabs relative to the root level (a remnant of the prior system.getInstaller layout where the arrow function started on its own indented line). Now that the arrow function opens inline with cordova.exec(, the body and closing brace are over-indented by one level compared to convention.

Suggested change
cordova.exec(
(installer) => {
config.IAP_AVAILABLE =
typeof iap !== "undefined" &&
installer != null &&
installer !== "null" &&
installer === "com.android.vending";
},
(error) => {
console.error(error);
config.IAP_AVAILABLE = typeof iap !== "undefined";
},
'System', 'getInstaller', []);

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Comment thread src/lib/config.js
Comment on lines 55 to +65
@@ -62,7 +62,6 @@ system.getInstaller(
(error) => {
console.error(error);
config.IAP_AVAILABLE = typeof iap !== "undefined";
},
);
}, 'System', 'getInstaller', []);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Direct cordova.exec call bypasses the plugin abstraction

system.getInstaller (defined in src/plugins/system/www/plugin.js) was the canonical entry point for this operation. Replacing it with hardcoded cordova.exec(..., 'System', 'getInstaller', []) strings means any future rename of the service or action in the plugin won't be caught here automatically. Prefer calling system.getInstaller(success, error) if the reason the original call was removed is resolved, or leave a comment explaining why the direct call is necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant