Skip to content

Improve liquidity ads codec performance - #3344

Merged
t-bast merged 2 commits into
masterfrom
liquidity-ads-codec
Aug 12, 2026
Merged

Improve liquidity ads codec performance#3344
t-bast merged 2 commits into
masterfrom
liquidity-ads-codec

Conversation

@t-bast

@t-bast t-bast commented Aug 11, 2026

Copy link
Copy Markdown
Member

We improve the performance of the liquidity ads codec by ignoring unknown payment types, and simply checking whether the payment types we support are activated or not. We keep the unparsed bits as an encoded blob, like we do for unknown features.

We improve the performance of the liquidity ads codec by ignoring
unknown payment types, and simply checking whether the payment types
we support are activated or not.
@t-bast t-bast changed the title Improve liquidity ads codec Improve liquidity ads codec performance Aug 11, 2026
@t-bast
t-bast requested review from pm47 and sstone August 11, 2026 13:14
If the liquidity ads TLVs is present but with empty fields, we fail to
correctly re-encode it. We must reject it immediately instead.
@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 92.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.63%. Comparing base (d769db0) to head (52bb6f4).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...main/scala/fr/acinq/eclair/router/Validation.scala 33.33% 2 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3344      +/-   ##
==========================================
- Coverage   88.64%   88.63%   -0.02%     
==========================================
  Files         222      222              
  Lines       21910    21917       +7     
  Branches      867      883      +16     
==========================================
+ Hits        19423    19426       +3     
- Misses       2487     2491       +4     
Files with missing lines Coverage Δ
...a/fr/acinq/eclair/wire/protocol/LiquidityAds.scala 95.29% <100.00%> (+0.11%) ⬆️
...main/scala/fr/acinq/eclair/router/Validation.scala 92.85% <33.33%> (-0.50%) ⬇️

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@t-bast
t-bast merged commit b6b89e0 into master Aug 12, 2026
1 check passed
@t-bast
t-bast deleted the liquidity-ads-codec branch August 12, 2026 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants