Improve liquidity ads codec performance - #3344
Merged
Merged
Conversation
We improve the performance of the liquidity ads codec by ignoring unknown payment types, and simply checking whether the payment types we support are activated or not.
If the liquidity ads TLVs is present but with empty fields, we fail to correctly re-encode it. We must reject it immediately instead.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3344 +/- ##
==========================================
- Coverage 88.64% 88.63% -0.02%
==========================================
Files 222 222
Lines 21910 21917 +7
Branches 867 883 +16
==========================================
+ Hits 19423 19426 +3
- Misses 2487 2491 +4
🚀 New features to boost your workflow:
|
sstone
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We improve the performance of the liquidity ads codec by ignoring unknown payment types, and simply checking whether the payment types we support are activated or not. We keep the unparsed bits as an encoded blob, like we do for unknown features.