Report the OpenCL error code when command queue creation fails - #59
Merged
Merged
Conversation
createQueue passed NULL for errcode_ret and threw a bare std::runtime_error, so a failure gave no indication of what the runtime had actually rejected. That is why the malformed property list fixed in #58 went unnoticed for years: the driver was returning CL_INVALID_VALUE and the message discarded it. Capture errcode_ret and route it through the existing OpenCLException, which formats the code into the message. The same failure now reports "failed to create command queue (res = -30)". The NULL guard is kept so a driver that returns NULL alongside CL_SUCCESS is still caught. Co-authored-by: Gleb Alekseev <alekseev.gleb@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
createQueue passed NULL for errcode_ret and threw a bare std::runtime_error, so a failure gave no indication of what the runtime had actually rejected. That is why the malformed property list fixed in #58 went unnoticed for years: the driver was returning CL_INVALID_VALUE and the message discarded it.
Capture errcode_ret and route it through the existing OpenCLException, which formats the code into the message. The same failure now reports "failed to create command queue (res = -30)".
The NULL guard is kept so a driver that returns NULL alongside CL_SUCCESS is still caught.