doesn't respect webpack configuration if more than one is exported #56

Activity

1. quilicicf commented on Jun 14, 2018

   

   quilicicf

   on Jun 14, 2018

   More actions

   Stumbled upon the second issue too (the last definition of onBuildEnd overwrites the previously defined one).
   I was doing something like this:

   In webpack.config.js:

   const webpackConfigDev = require('./webpack/webpack.config.dev');
   const webpackConfigProd = require('./webpack/webpack.config.prod');
   const ENV = { DEV: 'dev', PROD: 'prod' };
   
   module.exports = ({ NODE_ENV = ENV.DEV }) => {
     switch (NODE_ENV) {
       case ENV.DEV:
         return webpackConfigDev;
   
       case ENV.PROD:
         return webpackConfigProd;
   
       default:
         throw Error(`Unknown environment ${NODE_ENV}`);
     }
   };

   In webpack/webpack.config.dev.js:

   const WebpackShellPlugin = require('webpack-shell-plugin');
   const baseConfig = require('./webpack.config.base');
   
   module.exports = {
     ...baseConfig,
     plugins: [
       ...baseConfig.plugins,
       new WebpackShellPlugin({
         onBuildEnd: `do dev-related things`,
       }),
     ],
   };

   In webpack/webpack.config.prod.js:

   const WebpackShellPlugin = require('webpack-shell-plugin');
   const baseConfig = require('./webpack.config.base');
   
   module.exports = {
     ...baseConfig,
     plugins: [
       ...baseConfig.plugins,
       new WebpackShellPlugin({
         onBuildEnd: `do prod-related things`,
       }),
     ],
   };

   And the last required config was overriding the plugin's configuration.