Skip to content

Commit 5568320

Browse files
authored
Fix submodule always building from HEAD instead of recorded commit (#415)
Remove `git submodule update --remote` which overwrites the submodule checkout with the latest remote HEAD, ignoring the commit recorded in the superproject. I noticed that builds produced by CI did not match the tagged version. The root cause turned out to be that after `git submodule update --init --depth 20` correctly checks out the commit pinned by the superproject, the subsequent `git submodule update --remote` immediately overwrites it with whatever is at the tip of the remote tracking branch. This means every build was effectively building from vim HEAD rather than the version the tag intended to release.
1 parent fd36b24 commit 5568320

1 file changed

Lines changed: 0 additions & 1 deletion

File tree

appveyor.bat

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,6 @@ echo TAG_NAME: %TAG_NAME%
194194

195195
@rem Get Vim source code
196196
git submodule update --init --depth 20
197-
git submodule update --remote
198197

199198
@rem Apply experimental patches
200199
pushd vim

0 commit comments

Comments
 (0)