Skip to content

refactor: remove deprecated Sass wrapper macros#7103

Merged
arcra merged 8 commits into
tensorflow:masterfrom
cdavalos7:feature/remove-sass-wrapper-deprecated
May 22, 2026
Merged

refactor: remove deprecated Sass wrapper macros#7103
arcra merged 8 commits into
tensorflow:masterfrom
cdavalos7:feature/remove-sass-wrapper-deprecated

Conversation

@cdavalos7

@cdavalos7 cdavalos7 commented May 7, 2026

Copy link
Copy Markdown
Contributor

Motivation for features / changes

Unblock internal LSC intended to remove workarounds for Sass and bad practices. Internal issue: b/508363660. This PR removes the wrappers for Sass build rules. Sass rules must directly declare their dependencies.

Per Sass build rules guidelines, wrapper macros are discouraged, and tf_external_sass_libray was relying on a loophole (passing a sass_library to another sass_library's srcs) that is being closed.

Technical description of changes

  • Replace tf_sass_binary,tf_sass_library, and tf_external_sass_libray wrappers with direct calls to sass_binary, sass_library, and npm_sass_library from @io_bazel_rules_sass.
  • Updated hash version rules_sass from 1.55.0 to 1.69.5
  • Replaces the angular_material_sass_deps target with a direct npm_sass_library call. This produces a SassInfo provider consumed via deps, complying with the rule that sass libraries must declare deps directly rather than passing one library to another's srcs.
  • Added include_paths = ["external/npm/node_modules"] to each sass_binary so dart-sass can resolve @use '@angular/material'. The old wrapper set this automatically, now it has to be set per target.

Detailed steps to verify changes work correctly (as executed by you)

  • BUILD
  • Standalone running
  • No console errors

cdavalos7 added 2 commits May 7, 2026 16:29
…_sass_library, tf_sass_library and tf_sass_lbinary with direct calls to sass_binary, sass_library, and npm_sass_library from @io_bazel_rules_sass.
@cdavalos7 cdavalos7 marked this pull request as ready for review May 8, 2026 17:35
@cdavalos7 cdavalos7 changed the title Replaced wrapped of Angular materials in Bazel. Replacing tf_external… refactor: remove deprecated Sass wrapper macros May 8, 2026
@cdavalos7 cdavalos7 requested a review from arcra May 8, 2026 17:35
Comment thread tensorboard/defs/defs.bzl
Comment thread tensorboard/webapp/BUILD Outdated
Comment thread WORKSPACE Outdated
@cdavalos7 cdavalos7 requested a review from arcra May 18, 2026 18:25
Comment thread WORKSPACE Outdated
@arcra arcra merged commit 2e19048 into tensorflow:master May 22, 2026
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants