refactor: remove deprecated Sass wrapper macros#7103
Merged
arcra merged 8 commits intoMay 22, 2026
Conversation
…_sass_library, tf_sass_library and tf_sass_lbinary with direct calls to sass_binary, sass_library, and npm_sass_library from @io_bazel_rules_sass.
arcra
requested changes
May 8, 2026
… label for @angular/material
…ILD' to allow the reference @angular/material
…ment in new file.
arcra
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
Unblock internal LSC intended to remove workarounds for Sass and bad practices. Internal issue: b/508363660. This PR removes the wrappers for Sass build rules. Sass rules must directly declare their dependencies.
Per Sass build rules guidelines, wrapper macros are discouraged, and tf_external_sass_libray was relying on a loophole (passing a sass_library to another sass_library's srcs) that is being closed.
Technical description of changes
tf_sass_binary,tf_sass_library, andtf_external_sass_libraywrappers with direct calls tosass_binary,sass_library, andnpm_sass_libraryfrom@io_bazel_rules_sass.include_paths = ["external/npm/node_modules"]to each sass_binary so dart-sass can resolve@use '@angular/material'. The old wrapper set this automatically, now it has to be set per target.Detailed steps to verify changes work correctly (as executed by you)