Skip to content

Commit f51740c

Browse files
fix(sqlserverflex): fix instance create without --acl flag (#1524)
SSD3RD-10751
1 parent 81b20d4 commit f51740c

2 files changed

Lines changed: 33 additions & 0 deletions

File tree

internal/cmd/beta/sqlserverflex/instance/create/create.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -217,6 +217,10 @@ func buildRequest(ctx context.Context, model *inputModel, apiClient sqlserverfle
217217
return req, err
218218
}
219219

220+
if model.ACL == nil {
221+
model.ACL = make([]string, 0)
222+
}
223+
220224
req = req.CreateInstancePayload(sqlserverflex.CreateInstancePayload{
221225
Name: model.InstanceName,
222226
Network: sqlserverflex.CreateInstancePayloadNetwork{

internal/cmd/beta/sqlserverflex/instance/create/create_test.go

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -419,6 +419,35 @@ func TestBuildRequest(t *testing.T) {
419419
},
420420
isValid: false,
421421
},
422+
{
423+
description: "nil acl",
424+
model: fixtureInputModel(
425+
func(model *inputModel) {
426+
model.ACL = nil
427+
}),
428+
listFlavorsResp: &sqlserverflex.ListFlavorsResponse{
429+
Flavors: []sqlserverflex.ListFlavors{
430+
{
431+
Id: testFlavorId,
432+
Cpu: int64(2),
433+
Memory: int64(4),
434+
},
435+
},
436+
},
437+
listStoragesResp: &sqlserverflex.ListStoragesResponse{
438+
StorageClasses: []sqlserverflex.FlavorStorageClassesStorageClass{{
439+
Class: "storage-class",
440+
}},
441+
StorageRange: sqlserverflex.FlavorStorageRange{
442+
Min: 10,
443+
Max: 100,
444+
},
445+
},
446+
isValid: true,
447+
expectedRequest: testClient.DefaultAPI.CreateInstance(testCtx, testProjectId, testRegion).CreateInstancePayload(fixturePayload(func(payload *sqlserverflex.CreateInstancePayload) {
448+
payload.Network.Acl = make([]string, 0)
449+
})),
450+
},
422451
}
423452

424453
for _, tt := range tests {

0 commit comments

Comments
 (0)