Skip to content

Commit f1dec43

Browse files
committed
fix(add-resource-dropdown): align sort tiebreaker with compareByOrder, document empty-folder omission
Use id.localeCompare as the sort tiebreaker in buildWorkflowFolderTree to match the sidebar's compareByOrder fallback (sortOrder → id) instead of name. Add a comment clarifying that empty folders are intentionally omitted from the tree view.
1 parent e1e9364 commit f1dec43

1 file changed

Lines changed: 5 additions & 4 deletions

File tree

  • apps/sim/app/workspace/[workspaceId]/home/components/mothership-view/components/add-resource-dropdown

apps/sim/app/workspace/[workspaceId]/home/components/mothership-view/components/add-resource-dropdown/add-resource-dropdown.tsx

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -153,28 +153,29 @@ export function buildWorkflowFolderTree(
153153
)
154154
const childWorkflows = byFolder.get(parentId) ?? []
155155

156-
const mixed: Array<{ sortOrder: number; name: string; node: WorkflowTreeNode }> = []
156+
const mixed: Array<{ sortOrder: number; id: string; node: WorkflowTreeNode }> = []
157157

158158
for (const f of childFolders) {
159159
const children = buildLevel(f.id)
160+
// Folders with no descendant workflows are intentionally omitted; they are still reachable via search.
160161
if (children.length === 0) continue
161162
mixed.push({
162163
sortOrder: (f.sortOrder as number) ?? 0,
163-
name: f.name,
164+
id: f.id,
164165
node: { kind: 'folder', id: f.id, name: f.name, children },
165166
})
166167
}
167168

168169
for (const w of childWorkflows) {
169170
mixed.push({
170171
sortOrder: (w.sortOrder as number) ?? 0,
171-
name: w.name,
172+
id: w.id,
172173
node: toWorkflowNode(w),
173174
})
174175
}
175176

176177
mixed.sort((a, b) =>
177-
a.sortOrder !== b.sortOrder ? a.sortOrder - b.sortOrder : a.name.localeCompare(b.name)
178+
a.sortOrder !== b.sortOrder ? a.sortOrder - b.sortOrder : a.id.localeCompare(b.id)
178179
)
179180
return mixed.map((m) => m.node)
180181
}

0 commit comments

Comments
 (0)