Fix copilot trigger unsave

Author: Sg312

apps/sim/lib/copilot/tools/server/workflow/edit-workflow.ts

@@ -10,6 +10,7 @@ import { loadWorkflowFromNormalizedTables } from '@/lib/workflows/db-helpers'
 import { validateWorkflowState } from '@/lib/workflows/validation'
 import { getAllBlocks } from '@/blocks/registry'
 import { generateLoopBlocks, generateParallelBlocks } from '@/stores/workflows/workflow/utils'
+import { TRIGGER_RUNTIME_SUBBLOCK_IDS } from '@/triggers/consts'
 
 interface EditWorkflowOperation {
   operation_type: 'add' | 'edit' | 'delete' | 'insert_into_subflow' | 'extract_from_subflow'
@@ -307,6 +308,38 @@ function addConnectionsAsEdges(
   })
 }
 
+function applyTriggerConfigToBlockSubblocks(block: any, triggerConfig: Record<string, any>) {
+  if (!block?.subBlocks || !triggerConfig || typeof triggerConfig !== 'object') {
+    return
+  }
+
+  Object.entries(triggerConfig).forEach(([configKey, configValue]) => {
+    const existingSubblock = block.subBlocks[configKey]
+    if (existingSubblock) {
+      const existingValue = existingSubblock.value
+      const valuesEqual =
+        typeof existingValue === 'object' || typeof configValue === 'object'
+          ? JSON.stringify(existingValue) === JSON.stringify(configValue)
+          : existingValue === configValue
+
+      if (valuesEqual) {
+        return
+      }
+
+      block.subBlocks[configKey] = {
+        ...existingSubblock,
+        value: configValue,
+      }
+    } else {
+      block.subBlocks[configKey] = {
+        id: configKey,
+        type: 'short-input',
+        value: configValue,
+      }
+    }
+  })
+}
+
 /**
  * Apply operations directly to the workflow JSON state
  */
@@ -405,6 +438,9 @@ function applyOperationsToWorkflowState(
           if (params?.inputs) {
             if (!block.subBlocks) block.subBlocks = {}
             Object.entries(params.inputs).forEach(([key, value]) => {
+              if (TRIGGER_RUNTIME_SUBBLOCK_IDS.includes(key)) {
+                return
+              }
               let sanitizedValue = value
 
               // Special handling for inputFormat - ensure it's an array
@@ -432,10 +468,26 @@ function applyOperationsToWorkflowState(
                   value: sanitizedValue,
                 }
               } else {
-                block.subBlocks[key].value = sanitizedValue
+                const existingValue = block.subBlocks[key].value
+                const valuesEqual =
+                  typeof existingValue === 'object' || typeof sanitizedValue === 'object'
+                    ? JSON.stringify(existingValue) === JSON.stringify(sanitizedValue)
+                    : existingValue === sanitizedValue
+
+                if (!valuesEqual) {
+                  block.subBlocks[key].value = sanitizedValue
+                }
               }
             })
 
+            if (
+              Object.prototype.hasOwnProperty.call(params.inputs, 'triggerConfig') &&
+              block.subBlocks.triggerConfig &&
+              typeof block.subBlocks.triggerConfig.value === 'object'
+            ) {
+              applyTriggerConfigToBlockSubblocks(block, block.subBlocks.triggerConfig.value)
+            }
+
             // Update loop/parallel configuration in block.data
             if (block.type === 'loop') {
               block.data = block.data || {}

apps/sim/lib/workflows/json-sanitizer.ts

@@ -1,6 +1,7 @@
 import type { Edge } from 'reactflow'
 import { sanitizeWorkflowForSharing } from '@/lib/workflows/credential-extractor'
 import type { BlockState, Loop, Parallel, WorkflowState } from '@/stores/workflows/workflow/types'
+import { TRIGGER_PERSISTED_SUBBLOCK_IDS } from '@/triggers/consts'
 
 /**
  * Sanitized workflow state for copilot (removes all UI-specific data)
@@ -68,6 +69,10 @@ export interface ExportWorkflowState {
  * Check if a subblock contains sensitive/secret data
  */
 function isSensitiveSubBlock(key: string, subBlock: BlockState['subBlocks'][string]): boolean {
+  if (TRIGGER_PERSISTED_SUBBLOCK_IDS.includes(key)) {
+    return false
+  }
+
   // Check if it's an OAuth input type
   if (subBlock.type === 'oauth-input') {
     return true

apps/sim/lib/workflows/training/compute-edit-sequence.ts

@@ -1,4 +1,5 @@
 import type { CopilotWorkflowState } from '@/lib/workflows/json-sanitizer'
+import { TRIGGER_RUNTIME_SUBBLOCK_IDS } from '@/triggers/consts'
 
 export interface EditOperation {
   operation_type: 'add' | 'edit' | 'delete' | 'insert_into_subflow' | 'extract_from_subflow'
@@ -502,6 +503,9 @@ function computeInputDelta(
   const delta: Record<string, any> = {}
 
   for (const key in endInputs) {
+    if (TRIGGER_RUNTIME_SUBBLOCK_IDS.includes(key)) {
+      continue
+    }
     if (
       !(key in startInputs) ||
       JSON.stringify(startInputs[key]) !== JSON.stringify(endInputs[key])

apps/sim/stores/workflows/server-utils.ts

@@ -10,8 +10,6 @@
 
 import type { BlockState, SubBlockState } from '@/stores/workflows/workflow/types'
 
-const WEBHOOK_SUBBLOCK_FIELDS = ['webhookId', 'triggerPath']
-
 /**
  * Server-safe version of mergeSubblockState for API routes
  *
@@ -44,11 +42,10 @@ export function mergeSubblockState(
       const blockValues = subBlockValues[id] || {}
 
       // Create a deep copy of the block's subBlocks to maintain structure
-      // Exclude webhook-specific fields that should not be persisted
       const mergedSubBlocks = Object.entries(blockSubBlocks).reduce(
         (subAcc, [subBlockId, subBlock]) => {
-          // Skip if subBlock is undefined or is a webhook-specific field
-          if (!subBlock || WEBHOOK_SUBBLOCK_FIELDS.includes(subBlockId)) {
+          // Skip if subBlock is undefined
+          if (!subBlock) {
             return subAcc
           }
 
@@ -78,8 +75,7 @@ export function mergeSubblockState(
         if (
           !mergedSubBlocks[subBlockId] &&
           value !== null &&
-          value !== undefined &&
-          !WEBHOOK_SUBBLOCK_FIELDS.includes(subBlockId)
+          value !== undefined
         ) {
           // Create a minimal subblock structure
           mergedSubBlocks[subBlockId] = {

apps/sim/stores/workflows/utils.ts

@@ -1,8 +1,6 @@
 import { useSubBlockStore } from '@/stores/workflows/subblock/store'
 import type { BlockState, SubBlockState } from '@/stores/workflows/workflow/types'
 
-const WEBHOOK_SUBBLOCK_FIELDS = ['webhookId', 'triggerPath']
-
 /**
  * Normalizes a block name for comparison by converting to lowercase and removing spaces
  * @param name - The block name to normalize
@@ -77,11 +75,10 @@ export function mergeSubblockState(
       const blockValues = workflowSubblockValues[id] || {}
 
       // Create a deep copy of the block's subBlocks to maintain structure
-      // Exclude webhook-specific fields that should not be persisted
       const mergedSubBlocks = Object.entries(blockSubBlocks).reduce(
         (subAcc, [subBlockId, subBlock]) => {
-          // Skip if subBlock is undefined or is a webhook-specific field
-          if (!subBlock || WEBHOOK_SUBBLOCK_FIELDS.includes(subBlockId)) {
+          // Skip if subBlock is undefined
+          if (!subBlock) {
             return subAcc
           }
 
@@ -122,8 +119,7 @@ export function mergeSubblockState(
         if (
           !mergedSubBlocks[subBlockId] &&
           value !== null &&
-          value !== undefined &&
-          !WEBHOOK_SUBBLOCK_FIELDS.includes(subBlockId)
+          value !== undefined
         ) {
           // Create a minimal subblock structure
           mergedSubBlocks[subBlockId] = {
@@ -174,8 +170,8 @@ export async function mergeSubblockStateAsync(
       // Process all subblocks in parallel
       const subBlockEntries = await Promise.all(
         Object.entries(block.subBlocks).map(async ([subBlockId, subBlock]) => {
-          // Skip if subBlock is undefined or webhook-specific
-          if (!subBlock || WEBHOOK_SUBBLOCK_FIELDS.includes(subBlockId)) {
+          // Skip if subBlock is undefined
+          if (!subBlock) {
             return null
           }
 

apps/sim/triggers/consts.ts

@@ -14,3 +14,29 @@ export const SYSTEM_SUBBLOCK_IDS: string[] = [
   'triggerId', // Stored trigger ID
   'selectedTriggerId', // Selected trigger from dropdown (multi-trigger blocks)
 ]
+
+/**
+ * Trigger-related subblock IDs whose values should be persisted and
+ * propagated when workflows are edited programmatically.
+ */
+export const TRIGGER_PERSISTED_SUBBLOCK_IDS: string[] = [
+  'triggerConfig',
+  'triggerCredentials',
+  'triggerId',
+  'selectedTriggerId',
+  'webhookId',
+  'triggerPath',
+  'testUrl',
+  'testUrlExpiresAt',
+]
+
+/**
+ * Trigger-related subblock IDs that represent runtime metadata. They should remain
+ * in the workflow state but must not be modified or cleared by diff operations.
+ */
+export const TRIGGER_RUNTIME_SUBBLOCK_IDS: string[] = [
+  'webhookId',
+  'triggerPath',
+  'testUrl',
+  'testUrlExpiresAt',
+]