Skip to content

Commit 7e943ec

Browse files
committed
fix build
1 parent e836ad2 commit 7e943ec

3 files changed

Lines changed: 12 additions & 14 deletions

File tree

apps/docs/content/docs/en/variables/environment-variables.mdx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,8 @@ When no workspace variable exists for a key, personal variables are used:
7575
- **Automated runs (API, webhook, schedule, deployed chat)**: Workflow owner's personal variables
7676

7777
<Callout type="info">
78-
Personal variables are best for testing. Use workspace variables for production workflows.</Callout>
78+
Personal variables are best for testing. Use workspace variables for production workflows.
79+
</Callout>
7980

8081
## Security Best Practices
8182

apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components-new/settings-modal/components/environment/environment.tsx

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ const logger = createLogger('EnvironmentVariables')
2727

2828
const GRID_COLS = 'grid grid-cols-[minmax(0,1fr)_8px_minmax(0,1fr)_auto] items-center'
2929
const ENV_VAR_PATTERN = /^[A-Za-z_][A-Za-z0-9_]*$/
30+
const PERSONAL_VAR_INDEX_OFFSET = 1000
3031
const PRIMARY_BUTTON_STYLES =
3132
'!bg-[var(--brand-tertiary-2)] !text-[var(--text-inverse)] hover:!bg-[var(--brand-tertiary-2)]/90'
3233

@@ -92,7 +93,7 @@ function VariableRow({
9293
value={envKey}
9394
onChange={(e) => isNew && onKeyChange(e.target.value)}
9495
placeholder='API_KEY'
95-
name={`env_key_${rowIndex}_${Math.random()}`}
96+
name={`env_key_${rowIndex}`}
9697
autoComplete='off'
9798
autoCapitalize='off'
9899
spellCheck='false'
@@ -115,7 +116,7 @@ function VariableRow({
115116
onBlur={onValueBlur}
116117
placeholder={isConflict ? 'Workspace override active' : 'Enter value'}
117118
disabled={!isNew || isConflict}
118-
name={`env_value_${rowIndex}_${Math.random()}`}
119+
name={`env_value_${rowIndex}`}
119120
autoComplete='off'
120121
autoCapitalize='off'
121122
spellCheck='false'
@@ -255,8 +256,8 @@ export function EnvironmentVariables({ registerBeforeLeaveHandler }: Environment
255256
...v,
256257
id: generateRowId(),
257258
}))
258-
setInitialPersonalVars(JSON.parse(JSON.stringify(vars)))
259-
setPersonalVars(JSON.parse(JSON.stringify(vars)))
259+
setInitialPersonalVars(structuredClone(vars))
260+
setPersonalVars(structuredClone(vars))
260261
}, [personalEnvData])
261262

262263
useEffect(() => {
@@ -270,8 +271,8 @@ export function EnvironmentVariables({ registerBeforeLeaveHandler }: Environment
270271
value,
271272
id: generateRowId(),
272273
}))
273-
setInitialWorkspaceVars(JSON.parse(JSON.stringify(vars)))
274-
setWorkspaceVars(JSON.parse(JSON.stringify(vars)))
274+
setInitialWorkspaceVars(structuredClone(vars))
275+
setWorkspaceVars(structuredClone(vars))
275276
}
276277
}, [workspaceEnvData])
277278

@@ -351,8 +352,8 @@ export function EnvironmentVariables({ registerBeforeLeaveHandler }: Environment
351352
)
352353

353354
const handleCancel = useCallback(() => {
354-
setPersonalVars(JSON.parse(JSON.stringify(initialPersonalVars)))
355-
setWorkspaceVars(JSON.parse(JSON.stringify(initialWorkspaceVars)))
355+
setPersonalVars(structuredClone(initialPersonalVars))
356+
setWorkspaceVars(structuredClone(initialWorkspaceVars))
356357
setShowUnsavedChanges(false)
357358
pendingProceedCallback.current?.()
358359
pendingProceedCallback.current = null
@@ -607,7 +608,7 @@ export function EnvironmentVariables({ registerBeforeLeaveHandler }: Environment
607608
value={v.value}
608609
isNew={true}
609610
focusedValueIndex={focusedValueIndex}
610-
rowIndex={originalIndex + 1000}
611+
rowIndex={originalIndex + PERSONAL_VAR_INDEX_OFFSET}
611612
onKeyChange={(val) => updatePersonalVar(originalIndex, 'key', val)}
612613
onValueChange={(val) => updatePersonalVar(originalIndex, 'value', val)}
613614
onValueFocus={handleValueFocus}

apps/sim/executor/execution/snapshot.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -64,10 +64,6 @@ export class ExecutionSnapshot {
6464
public readonly state?: SerializableExecutionState
6565
) {}
6666

67-
get environmentVariables(): Record<string, string> {
68-
return {}
69-
}
70-
7167
toJSON(): string {
7268
return JSON.stringify({
7369
metadata: this.metadata,

0 commit comments

Comments
 (0)