Skip to content

Commit 50a875b

Browse files
waleedlatif1claude
andcommitted
fix(tables): remove source column dimming during drag reorder
Only show the insertion line at the drop position, matching Google Sheets behavior. Remove dragSourceBounds memo and isDragging prop. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent f03cec3 commit 50a875b

1 file changed

Lines changed: 0 additions & 21 deletions

File tree

  • apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/table

apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/table/table.tsx

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -367,17 +367,6 @@ export function Table({
367367
return null
368368
}, [dropTargetColumnName, dragColumnName, dropSide, displayColumns, columnWidths])
369369

370-
const dragSourceBounds = useMemo(() => {
371-
if (!dragColumnName) return null
372-
let left = CHECKBOX_COL_WIDTH
373-
for (const col of displayColumns) {
374-
const w = columnWidths[col.name] ?? COL_WIDTH
375-
if (col.name === dragColumnName) return { left, width: w }
376-
left += w
377-
}
378-
return null
379-
}, [dragColumnName, displayColumns, columnWidths])
380-
381370
const isAllRowsSelected = useMemo(() => {
382371
if (checkedRows.size > 0 && rows.length > 0 && checkedRows.size >= rows.length) {
383372
for (const row of rows) {
@@ -1968,7 +1957,6 @@ export function Table({
19681957
onResizeStart={handleColumnResizeStart}
19691958
onResize={handleColumnResize}
19701959
onResizeEnd={handleColumnResizeEnd}
1971-
isDragging={dragColumnName === column.name}
19721960
onDragStart={handleColumnDragStart}
19731961
onDragOver={handleColumnDragOver}
19741962
onDragEnd={handleColumnDragEnd}
@@ -2045,12 +2033,6 @@ export function Table({
20452033
style={{ left: resizeIndicatorLeft }}
20462034
/>
20472035
)}
2048-
{dragSourceBounds !== null && (
2049-
<div
2050-
className='pointer-events-none absolute top-0 z-[15] h-full bg-[var(--bg)] opacity-50'
2051-
style={{ left: dragSourceBounds.left, width: dragSourceBounds.width }}
2052-
/>
2053-
)}
20542036
{dropColumnBounds !== null && (
20552037
<>
20562038
<div
@@ -2898,7 +2880,6 @@ const ColumnHeaderMenu = React.memo(function ColumnHeaderMenu({
28982880
onResizeStart,
28992881
onResize,
29002882
onResizeEnd,
2901-
isDragging,
29022883
onDragStart,
29032884
onDragOver,
29042885
onDragEnd,
@@ -2923,7 +2904,6 @@ const ColumnHeaderMenu = React.memo(function ColumnHeaderMenu({
29232904
onResizeStart: (columnName: string) => void
29242905
onResize: (columnName: string, width: number) => void
29252906
onResizeEnd: () => void
2926-
isDragging?: boolean
29272907
onDragStart?: (columnName: string) => void
29282908
onDragOver?: (columnName: string, side: 'left' | 'right') => void
29292909
onDragEnd?: () => void
@@ -3045,7 +3025,6 @@ const ColumnHeaderMenu = React.memo(function ColumnHeaderMenu({
30453025
<th
30463026
className={cn(
30473027
'group relative border-[var(--border)] border-r border-b bg-[var(--bg)] p-0 text-left align-middle',
3048-
isDragging && 'opacity-40',
30493028
isColumnSelected && 'bg-[rgba(37,99,235,0.06)]'
30503029
)}
30513030
draggable={!readOnly && !isRenaming}

0 commit comments

Comments
 (0)