Commit 4f1e44e
fix(tables): address audit findings across table, undo hook, and store
- Add missing bounds check in handleCopy (c >= cols.length) matching
handleCut for defensive consistency
- Clear lastCheckboxRowRef in Ctrl+Space and Shift+Space to prevent
stale shift-click checkbox range after keyboard selection
- Fix stale snapshot race in patchRedoRowId/patchUndoRowId by reading
state inside the set() updater instead of via get() outside it
- Add metadata cleanup to create-column undo so column width is removed
from both local state and server, symmetric with delete-column redo
- Remove stale width key from columnWidths on column delete instead of
persisting orphaned entries
- Normalize undefined vs null in handleInlineSave change detection to
prevent unnecessary mutations when oldValue is undefined
- Use ghost.parentNode?.removeChild instead of document.body.removeChild
in drag ghost cleanup to prevent throw on component unmount
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>1 parent 659e02e commit 4f1e44e
File tree
3 files changed
+51
-28
lines changed- apps/sim
- app/workspace/[workspaceId]/tables/[tableId]/components/table
- hooks
- stores/table
3 files changed
+51
-28
lines changedLines changed: 15 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1025 | 1025 | | |
1026 | 1026 | | |
1027 | 1027 | | |
| 1028 | + | |
1028 | 1029 | | |
1029 | 1030 | | |
1030 | 1031 | | |
| |||
1038 | 1039 | | |
1039 | 1040 | | |
1040 | 1041 | | |
| 1042 | + | |
1041 | 1043 | | |
1042 | 1044 | | |
1043 | 1045 | | |
| |||
1354 | 1356 | | |
1355 | 1357 | | |
1356 | 1358 | | |
| 1359 | + | |
1357 | 1360 | | |
1358 | 1361 | | |
1359 | 1362 | | |
| |||
1593 | 1596 | | |
1594 | 1597 | | |
1595 | 1598 | | |
1596 | | - | |
1597 | | - | |
| 1599 | + | |
| 1600 | + | |
| 1601 | + | |
1598 | 1602 | | |
1599 | 1603 | | |
1600 | 1604 | | |
1601 | 1605 | | |
1602 | 1606 | | |
1603 | 1607 | | |
1604 | | - | |
| 1608 | + | |
1605 | 1609 | | |
1606 | 1610 | | |
1607 | 1611 | | |
| |||
1806 | 1810 | | |
1807 | 1811 | | |
1808 | 1812 | | |
| 1813 | + | |
| 1814 | + | |
| 1815 | + | |
| 1816 | + | |
1809 | 1817 | | |
1810 | 1818 | | |
1811 | 1819 | | |
1812 | 1820 | | |
1813 | | - | |
| 1821 | + | |
1814 | 1822 | | |
1815 | 1823 | | |
| 1824 | + | |
| 1825 | + | |
1816 | 1826 | | |
1817 | 1827 | | |
1818 | 1828 | | |
| |||
3147 | 3157 | | |
3148 | 3158 | | |
3149 | 3159 | | |
3150 | | - | |
| 3160 | + | |
3151 | 3161 | | |
3152 | 3162 | | |
3153 | 3163 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
202 | 202 | | |
203 | 203 | | |
204 | 204 | | |
205 | | - | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
206 | 215 | | |
207 | 216 | | |
208 | 217 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
150 | 150 | | |
151 | 151 | | |
152 | 152 | | |
153 | | - | |
154 | | - | |
155 | | - | |
156 | | - | |
157 | | - | |
158 | | - | |
159 | | - | |
160 | | - | |
161 | | - | |
162 | | - | |
163 | | - | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
164 | 166 | | |
165 | 167 | | |
166 | 168 | | |
167 | | - | |
168 | | - | |
169 | | - | |
170 | | - | |
171 | | - | |
172 | | - | |
173 | | - | |
174 | | - | |
175 | | - | |
176 | | - | |
177 | | - | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
178 | 182 | | |
179 | 183 | | |
180 | 184 | | |
| |||
0 commit comments