logs UX consistency between success and error cases

Author: icecrasher321

apps/sim/app/workspace/[workspaceId]/logs/components/trace-spans/trace-spans-display.tsx

@@ -63,16 +63,13 @@ function normalizeChildWorkflowSpan(span: TraceSpan): TraceSpan {
   const mergedChildren = mergeTraceSpanChildren(normalizedChildren, outputChildSpans)
 
   if (enrichedSpan.output && 'childTraceSpans' in enrichedSpan.output) {
-    enrichedSpan.output = { ...(enrichedSpan.output as Record<string, unknown>) }(
-      enrichedSpan.output as { childTraceSpans?: TraceSpan[] }
-    ).childTraceSpans = undefined
+    const { childTraceSpans, ...cleanOutput } = enrichedSpan.output as {
+      childTraceSpans?: TraceSpan[]
+    } & Record<string, unknown>
+    enrichedSpan.output = cleanOutput
   }
 
-  if (mergedChildren.length > 0) {
-    enrichedSpan.children = mergedChildren
-  } else if ('children' in enrichedSpan) {
-    enrichedSpan.children = undefined
-  }
+  enrichedSpan.children = mergedChildren.length > 0 ? mergedChildren : undefined
 
   return enrichedSpan
 }

apps/sim/executor/handlers/workflow/workflow-handler.ts

@@ -402,7 +402,6 @@ export class WorkflowBlockHandler implements BlockHandler {
 
     return {
       ...span,
-      name: this.cleanChildSpanName(span.name, childWorkflowName),
       metadata,
       ...(transformedChildren ? { children: transformedChildren } : {}),
     }
@@ -481,31 +480,6 @@ export class WorkflowBlockHandler implements BlockHandler {
     return !span.blockId
   }
 
-  /**
-   * Cleans up child span names for readability
-   */
-  private cleanChildSpanName(spanName: string, childWorkflowName: string): string {
-    if (spanName.includes(`${childWorkflowName}:`)) {
-      const cleanName = spanName.replace(`${childWorkflowName}:`, '').trim()
-
-      if (cleanName === 'Workflow Execution') {
-        return `${childWorkflowName} workflow`
-      }
-
-      if (cleanName.startsWith('Agent ')) {
-        return `${cleanName}`
-      }
-
-      return `${cleanName}`
-    }
-
-    if (spanName === 'Workflow Execution') {
-      return `${childWorkflowName} workflow`
-    }
-
-    return `${spanName}`
-  }
-
   /**
    * Maps child workflow output to parent block output
    */

apps/sim/lib/logs/execution/trace-spans/trace-spans.test.ts

@@ -588,6 +588,7 @@ describe('buildTraceSpans', () => {
       id: 'nested-workflow-span',
       name: 'Nested Workflow Block',
       type: 'workflow',
+      blockId: 'nested-workflow-block-id',
       duration: 3000,
       startTime: '2024-01-01T10:00:01.000Z',
       endTime: '2024-01-01T10:00:04.000Z',
@@ -703,7 +704,7 @@ describe('buildTraceSpans', () => {
 
     const rainbowCupcakeSpan = {
       id: 'rainbow-workflow-span',
-      name: 'rainbow-cupcake workflow',
+      name: 'Rainbow Cupcake',
       type: 'workflow',
       duration: 300,
       startTime: '2024-01-01T10:01:02.000Z',
@@ -748,16 +749,20 @@ describe('buildTraceSpans', () => {
     expect(traceSpans).toHaveLength(1)
     const workflowExecutionSpan = traceSpans[0]
     expect(workflowExecutionSpan.name).toBe('Workflow Execution')
+    expect(workflowExecutionSpan.status).toBe('error')
     expect(workflowExecutionSpan.children).toBeDefined()
     expect(workflowExecutionSpan.children).toHaveLength(1)
 
     const silkPondSpan = workflowExecutionSpan.children?.[0]
-    expect(silkPondSpan?.name).toBe('silk-pond workflow')
+    expect(silkPondSpan?.name).toBe('Silk Pond')
+    expect(silkPondSpan?.status).toBe('error')
     expect(silkPondSpan?.children).toBeDefined()
     expect(silkPondSpan?.children).toHaveLength(1)
 
     const rainbowSpan = silkPondSpan?.children?.[0]
-    expect(rainbowSpan?.name).toBe('rainbow-cupcake workflow')
+    expect(rainbowSpan?.name).toBe('Rainbow Cupcake')
+    expect(rainbowSpan?.status).toBe('error')
+    expect(rainbowSpan?.type).toBe('workflow')
     expect(rainbowSpan?.children).toBeDefined()
     expect(rainbowSpan?.children).toHaveLength(1)
 

apps/sim/lib/logs/execution/trace-spans/trace-spans.ts

@@ -110,11 +110,8 @@ export function buildTraceSpans(result: ExecutionResult): {
       }
     }
 
-    // Prefer human-friendly workflow block naming if provided by child execution mapping
-    const displayName =
-      isWorkflowBlockType(log.blockType) && log.output?.childWorkflowName
-        ? `${log.output.childWorkflowName} workflow`
-        : log.blockName || log.blockId
+    // Use block name consistently for all block types
+    const displayName = log.blockName || log.blockId
 
     const span: TraceSpan = {
       id: spanId,
@@ -282,12 +279,6 @@ export function buildTraceSpans(result: ExecutionResult): {
       const childTraceSpans = log.output.childTraceSpans as TraceSpan[]
       const flattenedChildren = flattenWorkflowChildren(childTraceSpans)
       span.children = mergeTraceSpanChildren(span.children || [], flattenedChildren)
-
-      // Workflow blocks that successfully executed a child workflow should show as success
-      // even if the child workflow failed - only the actual failing block should show as error
-      if (log.error && span.children.length > 0) {
-        span.status = 'success'
-      }
     }
 
     // Store in map
@@ -661,16 +652,13 @@ function ensureNestedWorkflowsProcessed(span: TraceSpan): TraceSpan {
   const mergedChildren = mergeTraceSpanChildren(normalizedChildren, outputChildSpans)
 
   if (processedSpan.output && 'childTraceSpans' in processedSpan.output) {
-    processedSpan.output = { ...(processedSpan.output as Record<string, unknown>) }(
-      processedSpan.output as { childTraceSpans?: TraceSpan[] }
-    ).childTraceSpans = undefined
+    const { childTraceSpans, ...cleanOutput } = processedSpan.output as {
+      childTraceSpans?: TraceSpan[]
+    } & Record<string, unknown>
+    processedSpan.output = cleanOutput
   }
 
-  if (mergedChildren.length > 0) {
-    processedSpan.children = mergedChildren
-  } else if ('children' in processedSpan) {
-    processedSpan.children = undefined
-  }
+  processedSpan.children = mergedChildren.length > 0 ? mergedChildren : undefined
 
   return processedSpan
 }