ci: bump codecov-action to v6 and fail CI on upload error#1142
Open
timtreis wants to merge 2 commits into
Open
ci: bump codecov-action to v6 and fail CI on upload error#1142timtreis wants to merge 2 commits into
timtreis wants to merge 2 commits into
Conversation
codecov-action@v5 verifies the codecov CLI against Codecov's old Keybase key, which they bricked after migrating accounts, so the upload step now fails with "Could not verify signature". v6 (= 6.0.2) ships the updated key. Also restores fail_ci_if_error: true (the cookiecutter-scverse template default) so a broken coverage upload surfaces as a CI failure instead of silently passing. Ref: codecov/codecov-action#1956 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1142 +/- ##
=======================================
Coverage 92.44% 92.44%
=======================================
Files 51 51
Lines 7811 7811
=======================================
Hits 7221 7221
Misses 590 590 🚀 New features to boost your workflow:
|
|
@timtreis Thanks for the fix. Could we also bump directly to v7? In case there are any more hotfix releases like v7.0.1, we would not need to bump again |
Member
Author
|
Hey @ajkswamy, the rational for |
LucaMarconato
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes to the coverage upload step:
codecov-action@v5->@v6. v5 verifies the codecov CLI binary against Codecov's old Keybase key, which they bricked after migrating accounts, so uploads now fail withCould not verify signature.@v6(= 6.0.2) ships the updated key.Restore
fail_ci_if_error: true. This matches thecookiecutter-scversetemplate default, so a broken coverage upload surfaces as a CI failure instead of silently passing (which is what masked this issue here until now).Ref: codecov/codecov-action#1956