Make inclusion of react-router (JS) optional

[catmando]

Comment from @barriehadfield:

The other gotcha I have gotten over is that Hyperlink Router includes its own source of React and this is a nightmare for me as I get into NPM version hell, so I use a fork with no source included and get React and ReactDOM via NPM

[janbiedermann]

Hyperloop.cancel_import in application.rb

[barriehadfield]

In application.rb or hyperloop.rb ?

[janbiedermann]

in app/javascripts/application.rb

[catmando]

I guess it works in either place... in the initializer it would be config.cancel_import ... and as @janbiedermann has discovered you can also call it from application.rb (I didn't realize that would work :-) )

My personal preference is in the initializer. More rails-ish. Just let the application.rb be a file that is never edited, and control config through the initializer or if working with JS files through the webpack stuff.

[janbiedermann]

should be documented, that when pulling in react or router or whatever js by node, webpacker whatever, hyperloop imports must be cancelled