From 423bf81149fbf7db9144e1c22063b7dba8d0e7b7 Mon Sep 17 00:00:00 2001 From: buongarzoni Date: Mon, 16 Nov 2026 02:07:32 -0300 Subject: [PATCH 1/5] fix(sender): add connect and read timeouts to SyncSender --- .../com/rollbar/notifier/config/Config.java | 22 ++++++- .../notifier/config/ConfigBuilder.java | 63 ++++++++++++++++++- .../rollbar/notifier/sender/SyncSender.java | 57 +++++++++++++++++ .../notifier/config/ConfigBuilderTest.java | 28 +++++++++ .../notifier/sender/SyncSenderTest.java | 63 +++++++++++++++++++ 5 files changed, 231 insertions(+), 2 deletions(-) diff --git a/rollbar-java/src/main/java/com/rollbar/notifier/config/Config.java b/rollbar-java/src/main/java/com/rollbar/notifier/config/Config.java index 4257bb7c..ec3738b9 100644 --- a/rollbar-java/src/main/java/com/rollbar/notifier/config/Config.java +++ b/rollbar-java/src/main/java/com/rollbar/notifier/config/Config.java @@ -2,7 +2,7 @@ import com.rollbar.notifier.Rollbar; import com.rollbar.notifier.sender.Sender; -import com.rollbar.notifier.sender.json.JsonSerializer; +import com.rollbar.notifier.sender.SyncSender; import java.net.Proxy; @@ -23,4 +23,24 @@ public interface Config extends CommonConfig { * @return the proxy. */ Proxy proxy(); + + /** + * Time in milliseconds the default sender waits while connecting to the Rollbar API. + * Ignored when a custom {@link #sender() sender} is configured. + * + * @return the connect timeout in milliseconds. + */ + default int connectTimeoutMillis() { + return SyncSender.DEFAULT_CONNECT_TIMEOUT_MILLIS; + } + + /** + * Time in milliseconds the default sender waits for data from the Rollbar API once connected. + * Ignored when a custom {@link #sender() sender} is configured. + * + * @return the read timeout in milliseconds. + */ + default int readTimeoutMillis() { + return SyncSender.DEFAULT_READ_TIMEOUT_MILLIS; + } } diff --git a/rollbar-java/src/main/java/com/rollbar/notifier/config/ConfigBuilder.java b/rollbar-java/src/main/java/com/rollbar/notifier/config/ConfigBuilder.java index e2fb894d..4f68e752 100644 --- a/rollbar-java/src/main/java/com/rollbar/notifier/config/ConfigBuilder.java +++ b/rollbar-java/src/main/java/com/rollbar/notifier/config/ConfigBuilder.java @@ -92,6 +92,10 @@ public class ConfigBuilder { protected boolean compressPayload; + protected int connectTimeoutMillis = SyncSender.DEFAULT_CONNECT_TIMEOUT_MILLIS; + + protected int readTimeoutMillis = SyncSender.DEFAULT_READ_TIMEOUT_MILLIS; + protected List redactedKeys; protected boolean useDefaultRedactedKeys = true; @@ -149,6 +153,8 @@ private ConfigBuilder(Config config) { this.defaultLevels = new DefaultLevels(config); this.truncateLargePayloads = config.truncateLargePayloads(); this.compressPayload = config.compressPayload(); + this.connectTimeoutMillis = config.connectTimeoutMillis(); + this.readTimeoutMillis = config.readTimeoutMillis(); this.maximumTelemetryData = config.maximumTelemetryData(); this.telemetryEventTracker = config.telemetryEventTracker(); this.redactedKeys = config.redactedKeys(); @@ -508,6 +514,43 @@ public ConfigBuilder compressPayload(boolean compress) { return this; } + /** + *

+ * Time in milliseconds the default sender waits while connecting to the Rollbar API. + * Default: {@value SyncSender#DEFAULT_CONNECT_TIMEOUT_MILLIS}. Zero means wait forever, which + * is not recommended. Ignored when a custom {@link #sender(Sender) sender} is set. + *

+ * @param connectTimeoutMillis the connect timeout in milliseconds. + * @return the builder instance. + * @throws IllegalArgumentException if the timeout is negative. + */ + public ConfigBuilder connectTimeoutMillis(int connectTimeoutMillis) { + this.connectTimeoutMillis = requireNonNegative(connectTimeoutMillis, "connectTimeoutMillis"); + return this; + } + + /** + *

+ * Time in milliseconds the default sender waits for data from the Rollbar API once connected. + * Default: {@value SyncSender#DEFAULT_READ_TIMEOUT_MILLIS}. Zero means wait forever, which is + * not recommended. Ignored when a custom {@link #sender(Sender) sender} is set. + *

+ * @param readTimeoutMillis the read timeout in milliseconds. + * @return the builder instance. + * @throws IllegalArgumentException if the timeout is negative. + */ + public ConfigBuilder readTimeoutMillis(int readTimeoutMillis) { + this.readTimeoutMillis = requireNonNegative(readTimeoutMillis, "readTimeoutMillis"); + return this; + } + + private static int requireNonNegative(int value, String name) { + if (value < 0) { + throw new IllegalArgumentException(name + " must not be negative: " + value); + } + return value; + } + /** *

* Maximum Telemetry events sent in a payload, only for the default TelemetryEventTracker, if @@ -595,7 +638,9 @@ public Config build() { new SyncSender.Builder(this.endpoint) .accessToken(accessToken) .proxy(proxy) - .compressPayload(this.compressPayload); + .compressPayload(this.compressPayload) + .connectTimeoutMillis(this.connectTimeoutMillis) + .readTimeoutMillis(this.readTimeoutMillis); if (this.jsonSerializer != null) { innerSender.jsonSerializer(this.jsonSerializer); } @@ -672,6 +717,10 @@ private static class ConfigImpl implements Config { private final boolean compressPayload; + private final int connectTimeoutMillis; + + private final int readTimeoutMillis; + private final int maximumTelemetryData; private final TelemetryEventTracker telemetryEventTracker; @@ -715,6 +764,8 @@ private static class ConfigImpl implements Config { this.defaultLevels = builder.defaultLevels; this.truncateLargePayloads = builder.truncateLargePayloads; this.compressPayload = builder.compressPayload; + this.connectTimeoutMillis = builder.connectTimeoutMillis; + this.readTimeoutMillis = builder.readTimeoutMillis; this.maximumTelemetryData = builder.maximumTelemetryData; this.telemetryEventTracker = builder.telemetryEventTracker; this.redactedKeys = builder.redactedKeys != null @@ -874,6 +925,16 @@ public boolean compressPayload() { return this.compressPayload; } + @Override + public int connectTimeoutMillis() { + return this.connectTimeoutMillis; + } + + @Override + public int readTimeoutMillis() { + return this.readTimeoutMillis; + } + @Override public int maximumTelemetryData() { return this.maximumTelemetryData; diff --git a/rollbar-java/src/main/java/com/rollbar/notifier/sender/SyncSender.java b/rollbar-java/src/main/java/com/rollbar/notifier/sender/SyncSender.java index 2a8f0cb3..e2d369a8 100755 --- a/rollbar-java/src/main/java/com/rollbar/notifier/sender/SyncSender.java +++ b/rollbar-java/src/main/java/com/rollbar/notifier/sender/SyncSender.java @@ -26,6 +26,16 @@ public class SyncSender extends AbstractSender { public static final String UTF_8 = "UTF-8"; + /** + * Default time in milliseconds to wait while establishing a connection to the Rollbar API. + */ + public static final int DEFAULT_CONNECT_TIMEOUT_MILLIS = 30_000; + + /** + * Default time in milliseconds to wait for data from the Rollbar API once connected. + */ + public static final int DEFAULT_READ_TIMEOUT_MILLIS = 30_000; + private final URL url; private final JsonSerializer jsonSerializer; @@ -36,12 +46,18 @@ public class SyncSender extends AbstractSender { private final boolean compressPayload; + private final int connectTimeoutMillis; + + private final int readTimeoutMillis; + SyncSender(Builder builder) { this.url = builder.url; this.jsonSerializer = builder.jsonSerializer; this.accessToken = builder.accessToken; this.proxy = builder.proxy != null ? builder.proxy : Proxy.NO_PROXY; this.compressPayload = builder.compressPayload; + this.connectTimeoutMillis = builder.connectTimeoutMillis; + this.readTimeoutMillis = builder.readTimeoutMillis; } @Override @@ -66,6 +82,10 @@ private HttpURLConnection getConnection() throws IOException { // By default, this will use the HTTPS Rollbar API URL defined in DEFAULT_API_ENDPOINT. HttpURLConnection connection = (HttpURLConnection) url.openConnection(this.proxy); + // Without these calls HttpURLConnection never times out, which could block the sender thread forever. + connection.setConnectTimeout(connectTimeoutMillis); + connection.setReadTimeout(readTimeoutMillis); + if (accessToken != null && !"".equals(accessToken)) { connection.setRequestProperty("x-rollbar-access-token", accessToken); } @@ -144,6 +164,10 @@ public static final class Builder { private boolean compressPayload = true; + private int connectTimeoutMillis = DEFAULT_CONNECT_TIMEOUT_MILLIS; + + private int readTimeoutMillis = DEFAULT_READ_TIMEOUT_MILLIS; + public Builder() { this(DEFAULT_API_ENDPOINT); } @@ -218,6 +242,32 @@ public Builder compressPayload(boolean compress) { return this; } + /** + * Time in milliseconds to wait while establishing a connection to the Rollbar API. + * Default: {@value SyncSender#DEFAULT_CONNECT_TIMEOUT_MILLIS}. Zero means wait forever, which + * is not recommended: a single unresponsive connection would stop all reporting. + * @param connectTimeoutMillis the connect timeout in milliseconds. + * @return the builder instance. + * @throws IllegalArgumentException if the timeout is negative. + */ + public Builder connectTimeoutMillis(int connectTimeoutMillis) { + this.connectTimeoutMillis = requireNonNegative(connectTimeoutMillis, "connectTimeoutMillis"); + return this; + } + + /** + * Time in milliseconds to wait for data from the Rollbar API once connected. + * Default: {@value SyncSender#DEFAULT_READ_TIMEOUT_MILLIS}. Zero means wait forever, which + * is not recommended: a single unresponsive connection would stop all reporting. + * @param readTimeoutMillis the read timeout in milliseconds. + * @return the builder instance. + * @throws IllegalArgumentException if the timeout is negative. + */ + public Builder readTimeoutMillis(int readTimeoutMillis) { + this.readTimeoutMillis = requireNonNegative(readTimeoutMillis, "readTimeoutMillis"); + return this; + } + /** * Builds the {@link SyncSender sync sender}. * @@ -227,6 +277,13 @@ public SyncSender build() { return new SyncSender(this); } + private static int requireNonNegative(int value, String name) { + if (value < 0) { + throw new IllegalArgumentException(name + " must not be negative: " + value); + } + return value; + } + private static URL parseUrl(String url) { try { URL result = new URL(url); diff --git a/rollbar-java/src/test/java/com/rollbar/notifier/config/ConfigBuilderTest.java b/rollbar-java/src/test/java/com/rollbar/notifier/config/ConfigBuilderTest.java index b8199ee7..c33a08bf 100644 --- a/rollbar-java/src/test/java/com/rollbar/notifier/config/ConfigBuilderTest.java +++ b/rollbar-java/src/test/java/com/rollbar/notifier/config/ConfigBuilderTest.java @@ -19,6 +19,7 @@ import com.rollbar.notifier.provider.notifier.NotifierProvider; import com.rollbar.notifier.sender.BufferedSender; import com.rollbar.notifier.sender.Sender; +import com.rollbar.notifier.sender.SyncSender; import com.rollbar.notifier.transformer.Transformer; import com.rollbar.notifier.uuid.UuidGenerator; import java.net.Proxy; @@ -97,6 +98,8 @@ public void shouldBuildConfigurationWithDefaults() { assertThat(config.handleUncaughtErrors(), is(true)); assertThat(config.isEnabled(), is(true)); assertThat(config.proxy(), is(nullValue())); + assertThat(config.connectTimeoutMillis(), is(SyncSender.DEFAULT_CONNECT_TIMEOUT_MILLIS)); + assertThat(config.readTimeoutMillis(), is(SyncSender.DEFAULT_READ_TIMEOUT_MILLIS)); assertThat(config.defaultMessageLevel(), equalTo(Level.WARNING)); assertThat(config.defaultThrowableLevel(), equalTo(Level.ERROR)); @@ -204,4 +207,29 @@ public void shouldBuildWithConfig() { assertThat(config.isEnabled(), is(copy.isEnabled())); assertThat(config.maximumTelemetryData(), is(maximumTelemetryData)); } + + @Test + public void shouldBuildWithTimeoutsAndCopyThem() { + Config config = ConfigBuilder.withAccessToken(ACCESS_TOKEN) + .connectTimeoutMillis(1234) + .readTimeoutMillis(5678) + .build(); + + Config copy = withConfig(config).build(); + + assertThat(config.connectTimeoutMillis(), is(1234)); + assertThat(config.readTimeoutMillis(), is(5678)); + assertThat(copy.connectTimeoutMillis(), is(1234)); + assertThat(copy.readTimeoutMillis(), is(5678)); + } + + @Test(expected = IllegalArgumentException.class) + public void shouldRejectNegativeConnectTimeout() { + ConfigBuilder.withAccessToken(ACCESS_TOKEN).connectTimeoutMillis(-1); + } + + @Test(expected = IllegalArgumentException.class) + public void shouldRejectNegativeReadTimeout() { + ConfigBuilder.withAccessToken(ACCESS_TOKEN).readTimeoutMillis(-1); + } } \ No newline at end of file diff --git a/rollbar-java/src/test/java/com/rollbar/notifier/sender/SyncSenderTest.java b/rollbar-java/src/test/java/com/rollbar/notifier/sender/SyncSenderTest.java index 4e4fcea6..0a6c9af8 100644 --- a/rollbar-java/src/test/java/com/rollbar/notifier/sender/SyncSenderTest.java +++ b/rollbar-java/src/test/java/com/rollbar/notifier/sender/SyncSenderTest.java @@ -23,7 +23,10 @@ import java.io.OutputStream; import java.util.zip.GZIPInputStream; import java.net.HttpURLConnection; +import java.net.InetAddress; import java.net.Proxy; +import java.net.ServerSocket; +import java.net.SocketTimeoutException; import java.net.URL; import org.junit.Before; import org.junit.Rule; @@ -252,6 +255,66 @@ public void shouldNotSetContentEncodingWhenCompressionDisabled() throws Exceptio org.mockito.ArgumentMatchers.anyString()); } + @Test + public void shouldApplyDefaultTimeouts() throws Exception { + when(connection.getResponseCode()).thenReturn(200); + when(connection.getInputStream()) + .thenReturn(new ByteArrayInputStream("{}".getBytes(UTF_8))); + + sut.send(payload); + + verify(connection).setConnectTimeout(SyncSender.DEFAULT_CONNECT_TIMEOUT_MILLIS); + verify(connection).setReadTimeout(SyncSender.DEFAULT_READ_TIMEOUT_MILLIS); + } + + @Test + public void shouldApplyConfiguredTimeouts() throws Exception { + when(connection.getResponseCode()).thenReturn(200); + when(connection.getInputStream()) + .thenReturn(new ByteArrayInputStream("{}".getBytes(UTF_8))); + + sut = new SyncSender.Builder() + .url(url) + .jsonSerializer(serializer) + .connectTimeoutMillis(1234) + .readTimeoutMillis(5678) + .build(); + + sut.send(payload); + + verify(connection).setConnectTimeout(1234); + verify(connection).setReadTimeout(5678); + } + + @Test(expected = IllegalArgumentException.class) + public void shouldRejectNegativeConnectTimeout() { + new SyncSender.Builder().connectTimeoutMillis(-1); + } + + @Test(expected = IllegalArgumentException.class) + public void shouldRejectNegativeReadTimeout() { + new SyncSender.Builder().readTimeoutMillis(-1); + } + + @Test(timeout = 10_000) + public void shouldFailInsteadOfHangingWhenServerNeverResponds() throws Exception { + // Accepts the connection (via the backlog) but never reads or writes anything. + try (ServerSocket silentServer = new ServerSocket(0, 1, InetAddress.getLoopbackAddress())) { + String endpoint = "http://127.0.0.1:" + silentServer.getLocalPort() + "/api/1/item/"; + SyncSender realSender = new SyncSender.Builder(endpoint) + .jsonSerializer(serializer) + .readTimeoutMillis(200) + .build(); + realSender.addListener(listener); + + realSender.send(payload); + + ArgumentCaptor argument = ArgumentCaptor.forClass(SenderException.class); + verify(listener).onError(eq(payload), argument.capture()); + assertThat(argument.getValue().getCause(), is(instanceOf(SocketTimeoutException.class))); + } + } + private void verifyHttp() throws Exception { verify(connection).setRequestProperty("Accept-Charset", UTF_8); verify(connection).setRequestProperty("Content-Type", "application/json; charset=" + UTF_8); From 15fbaa933557de9d9ce1a859b76361d4586065b4 Mon Sep 17 00:00:00 2001 From: buongarzoni Date: Mon, 16 Nov 2026 12:22:47 -0300 Subject: [PATCH 2/5] style(sender): wrap long comment in SyncSender --- .../src/main/java/com/rollbar/notifier/sender/SyncSender.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/rollbar-java/src/main/java/com/rollbar/notifier/sender/SyncSender.java b/rollbar-java/src/main/java/com/rollbar/notifier/sender/SyncSender.java index e2d369a8..634c6d24 100755 --- a/rollbar-java/src/main/java/com/rollbar/notifier/sender/SyncSender.java +++ b/rollbar-java/src/main/java/com/rollbar/notifier/sender/SyncSender.java @@ -82,7 +82,8 @@ private HttpURLConnection getConnection() throws IOException { // By default, this will use the HTTPS Rollbar API URL defined in DEFAULT_API_ENDPOINT. HttpURLConnection connection = (HttpURLConnection) url.openConnection(this.proxy); - // Without these calls HttpURLConnection never times out, which could block the sender thread forever. + // Without these calls HttpURLConnection never times out, which could block the sender + // thread forever. connection.setConnectTimeout(connectTimeoutMillis); connection.setReadTimeout(readTimeoutMillis); From b107848b12d26e554bb25ed7aeee637af6baaf42 Mon Sep 17 00:00:00 2001 From: buongarzoni Date: Mon, 16 Nov 2026 12:26:09 -0300 Subject: [PATCH 3/5] docs(config): clarify when timeout settings take effect --- .../rollbar/notifier/config/ConfigBuilder.java | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/rollbar-java/src/main/java/com/rollbar/notifier/config/ConfigBuilder.java b/rollbar-java/src/main/java/com/rollbar/notifier/config/ConfigBuilder.java index 4f68e752..33e22343 100644 --- a/rollbar-java/src/main/java/com/rollbar/notifier/config/ConfigBuilder.java +++ b/rollbar-java/src/main/java/com/rollbar/notifier/config/ConfigBuilder.java @@ -518,7 +518,13 @@ public ConfigBuilder compressPayload(boolean compress) { *

* Time in milliseconds the default sender waits while connecting to the Rollbar API. * Default: {@value SyncSender#DEFAULT_CONNECT_TIMEOUT_MILLIS}. Zero means wait forever, which - * is not recommended. Ignored when a custom {@link #sender(Sender) sender} is set. + * is not recommended. + *

+ *

+ * Only applies when this builder creates the default sender. It has no effect when a custom + * {@link #sender(Sender) sender} is set, or when the builder starts from an existing + * configuration, for example through {@code Rollbar.configure}, because that configuration's + * sender is reused. *

* @param connectTimeoutMillis the connect timeout in milliseconds. * @return the builder instance. @@ -533,7 +539,13 @@ public ConfigBuilder connectTimeoutMillis(int connectTimeoutMillis) { *

* Time in milliseconds the default sender waits for data from the Rollbar API once connected. * Default: {@value SyncSender#DEFAULT_READ_TIMEOUT_MILLIS}. Zero means wait forever, which is - * not recommended. Ignored when a custom {@link #sender(Sender) sender} is set. + * not recommended. + *

+ *

+ * Only applies when this builder creates the default sender. It has no effect when a custom + * {@link #sender(Sender) sender} is set, or when the builder starts from an existing + * configuration, for example through {@code Rollbar.configure}, because that configuration's + * sender is reused. *

* @param readTimeoutMillis the read timeout in milliseconds. * @return the builder instance. From 7ebf1d22c25f9f0ce535ecac637c69000f0c6eee Mon Sep 17 00:00:00 2001 From: buongarzoni Date: Mon, 16 Nov 2026 12:34:00 -0300 Subject: [PATCH 4/5] test(sender): bind silent server to the address the client connects to --- .../java/com/rollbar/notifier/sender/SyncSenderTest.java | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/rollbar-java/src/test/java/com/rollbar/notifier/sender/SyncSenderTest.java b/rollbar-java/src/test/java/com/rollbar/notifier/sender/SyncSenderTest.java index 0a6c9af8..ac75d6e8 100644 --- a/rollbar-java/src/test/java/com/rollbar/notifier/sender/SyncSenderTest.java +++ b/rollbar-java/src/test/java/com/rollbar/notifier/sender/SyncSenderTest.java @@ -298,9 +298,12 @@ public void shouldRejectNegativeReadTimeout() { @Test(timeout = 10_000) public void shouldFailInsteadOfHangingWhenServerNeverResponds() throws Exception { - // Accepts the connection (via the backlog) but never reads or writes anything. - try (ServerSocket silentServer = new ServerSocket(0, 1, InetAddress.getLoopbackAddress())) { - String endpoint = "http://127.0.0.1:" + silentServer.getLocalPort() + "/api/1/item/"; + // Accepts the connection (via the backlog) but never reads or writes anything. It binds to the + // same literal address the client connects to: getLoopbackAddress() returns ::1 when the JVM + // prefers IPv6, and the connection to 127.0.0.1 would then be refused instead of timing out. + String host = "127.0.0.1"; + try (ServerSocket silentServer = new ServerSocket(0, 1, InetAddress.getByName(host))) { + String endpoint = "http://" + host + ":" + silentServer.getLocalPort() + "/api/1/item/"; SyncSender realSender = new SyncSender.Builder(endpoint) .jsonSerializer(serializer) .readTimeoutMillis(200) From 710a31ba846574a4311068f1c92d0191811b776d Mon Sep 17 00:00:00 2001 From: buongarzoni Date: Mon, 16 Nov 2026 14:22:11 -0300 Subject: [PATCH 5/5] test(config): verify the default sender uses the configured read timeout --- .../notifier/config/ConfigBuilderTest.java | 38 +++++++++++++++++++ 1 file changed, 38 insertions(+) diff --git a/rollbar-java/src/test/java/com/rollbar/notifier/config/ConfigBuilderTest.java b/rollbar-java/src/test/java/com/rollbar/notifier/config/ConfigBuilderTest.java index c33a08bf..65f586db 100644 --- a/rollbar-java/src/test/java/com/rollbar/notifier/config/ConfigBuilderTest.java +++ b/rollbar-java/src/test/java/com/rollbar/notifier/config/ConfigBuilderTest.java @@ -6,7 +6,11 @@ import static org.hamcrest.Matchers.nullValue; import static org.hamcrest.core.Is.is; import static org.hamcrest.core.IsInstanceOf.instanceOf; +import static org.mockito.ArgumentMatchers.eq; +import static org.mockito.Mockito.mock; +import static org.mockito.Mockito.verify; +import com.rollbar.api.payload.Payload; import com.rollbar.api.payload.data.Client; import com.rollbar.api.payload.data.Level; import com.rollbar.api.payload.data.Notifier; @@ -20,12 +24,18 @@ import com.rollbar.notifier.sender.BufferedSender; import com.rollbar.notifier.sender.Sender; import com.rollbar.notifier.sender.SyncSender; +import com.rollbar.notifier.sender.exception.SenderException; +import com.rollbar.notifier.sender.listener.SenderListener; import com.rollbar.notifier.transformer.Transformer; import com.rollbar.notifier.uuid.UuidGenerator; +import java.net.InetAddress; import java.net.Proxy; +import java.net.ServerSocket; +import java.net.SocketTimeoutException; import java.util.Map; import org.junit.Rule; import org.junit.Test; +import org.mockito.ArgumentCaptor; import org.mockito.Mock; import org.mockito.junit.MockitoJUnit; import org.mockito.junit.MockitoRule; @@ -223,6 +233,34 @@ public void shouldBuildWithTimeoutsAndCopyThem() { assertThat(copy.readTimeoutMillis(), is(5678)); } + @Test(timeout = 10_000) + public void shouldApplyReadTimeoutToTheDefaultSender() throws Exception { + // Accepts the connection (via the backlog) but never responds. If the configured timeout did + // not reach the sender, it would wait for the 30 s default and this test would time out. + String host = "127.0.0.1"; + try (ServerSocket silentServer = new ServerSocket(0, 1, InetAddress.getByName(host))) { + Config config = ConfigBuilder.withAccessToken(ACCESS_TOKEN) + .endpoint("http://" + host + ":" + silentServer.getLocalPort() + "/api/1/item/") + .readTimeoutMillis(200) + .build(); + try { + Sender defaultSender = ((BufferedSender) config.sender()).sender(); + assertThat(defaultSender, is(instanceOf(SyncSender.class))); + SenderListener listener = mock(SenderListener.class); + defaultSender.addListener(listener); + Payload payload = new Payload("{}"); + + defaultSender.send(payload); + + ArgumentCaptor error = ArgumentCaptor.forClass(SenderException.class); + verify(listener).onError(eq(payload), error.capture()); + assertThat(error.getValue().getCause(), is(instanceOf(SocketTimeoutException.class))); + } finally { + config.sender().close(false); + } + } + } + @Test(expected = IllegalArgumentException.class) public void shouldRejectNegativeConnectTimeout() { ConfigBuilder.withAccessToken(ACCESS_TOKEN).connectTimeoutMillis(-1);