fix and questions

Author: Pierre-Sassoulas

testing/code/test_code.py

@@ -148,7 +148,7 @@ class TestExceptionInfo:
     def test_bad_getsource(self) -> None:
         try:
             if False:
-                pass
+                pass  # type: ignore[unreachable]
             else:
                 assert False
         except AssertionError:
@@ -164,7 +164,7 @@ class TestTracebackEntry:
     def test_getsource(self) -> None:
         try:
             if False:
-                pass
+                pass  # type: ignore[unreachable]
             else:
                 assert False
         except AssertionError:

testing/test_capture.py

@@ -920,7 +920,7 @@ def test_dontreadfrominput() -> None:
 
     f = DontReadFromInput()
     assert f.buffer is f  # type: ignore[comparison-overlap]
-    assert not f.isatty()
+    assert not f.isatty() # testing/test_capture.py:923: error: Statement is unreachable  [unreachable] ?!
     pytest.raises(OSError, f.read)
     pytest.raises(OSError, f.readlines)
     iter_f = iter(f)

testing/test_collection.py

@@ -83,6 +83,7 @@ def test_foo(self):
         fn = pytester.collect_by_name(cls, "test_foo")
         assert isinstance(fn, pytest.Function)
 
+        assert modcol is not None
         assert fn.getparent(pytest.Module) is modcol
         assert modcol.module is not None
         assert modcol.cls is None