Repository navigation
Commit c8657ac
build: derive NODE_ARCH from target_cpu in the GN build
unofficial.gni special-cased ia32 on current_cpu while every other
architecture used target_cpu. When node is also compiled in a host
toolchain of a cross build (for example node_mksnapshot running in
V8's snapshot toolchain, which is x86-hosted for 32-bit arm targets),
current_cpu is the host's, so NODE_ARCH became "ia32" for an
arm-targeted build and process.arch deserialized as 'ia32' on the
device. Key the special case off target_cpu like the rest.
Signed-off-by: Shelley Vohr <shelley.vohr@gmail.com>
PR-URL: #65491
Refs: electron/electron#52959
Reviewed-By: Filip Skokan <panva.ip@gmail.com>1 parent c9da26f commit c8657ac
1 file changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
94 | 94 | | |
95 | 95 | | |
96 | 96 | | |
97 | | - | |
| 97 | + | |
98 | 98 | | |
99 | 99 | | |
100 | 100 | | |
| |||
0 commit comments