fix(auto-upload): handle upload results

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>

Author: alperozturk96

app/src/main/java/com/nextcloud/client/jobs/autoUpload/AutoUploadWorker.kt

@@ -26,7 +26,7 @@ import com.nextcloud.client.jobs.upload.FileUploadWorker
 import com.nextcloud.client.jobs.utils.UploadErrorNotificationManager
 import com.nextcloud.client.network.ConnectivityService
 import com.nextcloud.client.preferences.SubFolderRule
-import com.nextcloud.utils.extensions.isPermanentFailure
+import com.nextcloud.utils.extensions.isNonRetryable
 import com.nextcloud.utils.extensions.updateStatus
 import com.owncloud.android.R
 import com.owncloud.android.datamodel.ArbitraryDataProviderImpl
@@ -416,11 +416,10 @@ class AutoUploadWorker(
         )
 
         val lastUploadResult = uploadEntity?.lastResult?.let { UploadResult.fromValue(it) }
-        if (lastUploadResult?.isPermanentFailure() == true) {
+        if (lastUploadResult?.isNonRetryable() == true) {
             Log_OC.w(
                 TAG,
-                "last upload failed with permanent failure, skipping auto-upload: $localPath," +
-                    " failure: ${lastUploadResult.value}"
+                "last upload failed with ${lastUploadResult.value}, skipping auto-upload: $localPath"
             )
             return AutoUploadEntityResult.PermanentFailure
         }

app/src/main/java/com/nextcloud/utils/extensions/UploadResultExtensions.kt

@@ -9,7 +9,7 @@ package com.nextcloud.utils.extensions
 
 import com.owncloud.android.db.UploadResult
 
-fun UploadResult.isPermanentFailure(): Boolean = when (this) {
+fun UploadResult.isNonRetryable(): Boolean = when (this) {
     UploadResult.FILE_NOT_FOUND,
     UploadResult.FILE_ERROR,
     UploadResult.FOLDER_ERROR,
@@ -26,6 +26,6 @@ fun UploadResult.isPermanentFailure(): Boolean = when (this) {
     // user's choice
     UploadResult.CANCELLED -> true
 
-    // Everything else may succeed after retry
+    // everything else may succeed after retry
     else -> false
 }