Skip to content

Commit 0c7b14c

Browse files
Merge pull request #16902 from nextcloud/backport/16901/stable-33.1.0
[stable-33.1.0] fix(upload-file-operation): wrong storage manager injection
2 parents 2d9582e + 1efe71b commit 0c7b14c

3 files changed

Lines changed: 5 additions & 7 deletions

File tree

app/src/main/java/com/nextcloud/client/jobs/upload/FileUploadWorker.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -271,7 +271,7 @@ class FileUploadWorker(
271271
}
272272

273273
fileUploadEventBroadcaster.sendUploadEnqueued(context)
274-
val operation = uploadFileOperationFactory.create(upload, this@FileUploadWorker)
274+
val operation = uploadFileOperationFactory.create(context, upload, this@FileUploadWorker)
275275
activeOperations[upload.uploadId] = operation
276276

277277
val currentIndex = (index + 1)

app/src/main/java/com/owncloud/android/operations/factory/UploadFileOperationFactory.kt

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,12 +24,10 @@ class UploadFileOperationFactory @Inject constructor(
2424
private val uploadsStorageManager: UploadsStorageManager,
2525
private val connectivityService: ConnectivityService,
2626
private val powerManagementService: PowerManagementService,
27-
private val context: Context,
28-
private val accountManager: UserAccountManager,
29-
private val fileDataStorageManager: FileDataStorageManager
27+
private val accountManager: UserAccountManager
3028
) {
31-
3229
fun create(
30+
context: Context,
3331
upload: OCUpload,
3432
progressListener: OnDatatransferProgressListener? = null,
3533
disableRetries: Boolean = true
@@ -46,7 +44,7 @@ class UploadFileOperationFactory @Inject constructor(
4644
upload.isUseWifiOnly,
4745
upload.isWhileChargingOnly,
4846
disableRetries,
49-
fileDataStorageManager
47+
FileDataStorageManager(accountManager.user, context.contentResolver)
5048
).apply {
5149
progressListener?.let { addDataTransferProgressListener(it) }
5250
}

app/src/main/java/com/owncloud/android/ui/activity/UploadListActivity.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -339,7 +339,7 @@ class UploadListActivity :
339339
}
340340

341341
val result = uploadFileOperationFactory
342-
.create(upload)
342+
.create(this@UploadListActivity, upload)
343343
.execute(client)
344344

345345
if (result.isSuccess) {

0 commit comments

Comments
 (0)