Some colors make error messages hard to read on white backgrounds.

[ayosec]

On a terminal with white background, some parts of the error messages are very hard to read:

Cause

The problem is that the diagnosticwriter is forcing the bright versions of the colors, instead of using the default colors set by the terminal configuration (by writing 9x instead of 3x):

https://github.com/microsoft/typescript-go/blob/168e7015edf98244febc8f4ae450b673b5d195d7/internal/diagnosticwriter/diagnosticwriter.go#L108-L112

If I patch the binary to replace the colors to 3x with this:

$ sed -i 's/\x1b\[9\(.\)m/\x1b[3\1m/g' ./node_modules/@typescript/typescript-linux-x64/lib/tsc

Then the output is much easier to read:

[jakebailey]

This is not new in v7, no?

TypeScript/src/compiler/program.ts

Lines 680 to 685 in 637d574

	export enum ForegroundColorEscapeSequences {
	Grey = "\u001b[90m",
	Red = "\u001b[91m",
	Yellow = "\u001b[93m",
	Blue = "\u001b[94m",
	Cyan = "\u001b[96m",

[ayosec]

This is not new in v7, no?

Yes, the same issue is in the original compiler.

Should I move the issue to the microsoft/TypeScript repository?