Skip to content

Commit c51e4df

Browse files
committed
Moved update code to app init to prevent constant check for updates during page refresh
1 parent 99a2c96 commit c51e4df

2 files changed

Lines changed: 7 additions & 14 deletions

File tree

src/EventLogExpert/MainPage.xaml.cs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,11 @@ public MainPage(
7676
_traceLogger = traceLogger;
7777
_updateService = updateService;
7878

79+
if (_currentVersionProvider.IsSupportedOS(DeviceInfo.Version))
80+
{
81+
_updateService.CheckForUpdates(_settings.IsPreReleaseEnabled, false).AndForget();
82+
}
83+
7984
activeLogsState.Select(e => e.ActiveLogs);
8085

8186
activeLogsState.SelectedValueChanged += (sender, activeLogs) =>

src/EventLogExpert/Shared/MainLayout.razor.cs

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
// // Copyright (c) Microsoft Corporation.
22
// // Licensed under the MIT License.
33

4-
using EventLogExpert.UI.Interfaces;
54
using EventLogExpert.UI.Services;
65
using EventLogExpert.UI.Store.FilterPane;
76
using Microsoft.AspNetCore.Components;
@@ -12,25 +11,14 @@ namespace EventLogExpert.Shared;
1211

1312
public sealed partial class MainLayout
1413
{
15-
[Inject] private IAppTitleService AppTitleService { get; init; } = null!;
16-
17-
[Inject] private ICurrentVersionProvider CurrentVersionProvider { get; init; } = null!;
18-
1914
[Inject] private IDispatcher Dispatcher { get; init; } = null!;
2015

21-
[Inject] private ISettingsService Settings { get; init; } = null!;
22-
23-
[Inject] private IUpdateService UpdateService { get; init; } = null!;
16+
[Inject] private IAppTitleService AppTitleService { get; init; } = null!;
2417

2518
protected override async Task OnAfterRenderAsync(bool firstRender)
2619
{
2720
if (firstRender)
2821
{
29-
if (CurrentVersionProvider.IsSupportedOS(DeviceInfo.Version))
30-
{
31-
await UpdateService.CheckForUpdates(Settings.IsPreReleaseEnabled, false);
32-
}
33-
3422
AppTitleService.SetLogName(null);
3523
}
3624

@@ -42,7 +30,7 @@ private void HandleKeyUp(KeyboardEventArgs args)
4230
// https://developer.mozilla.org/en-US/docs/Web/API/UI_Events/Keyboard_event_key_values
4331
switch (args)
4432
{
45-
case { CtrlKey: true, Code: "KeyH" } :
33+
case { CtrlKey: true, Code: "KeyH" }:
4634
Dispatcher.Dispatch(new FilterPaneAction.ToggleIsEnabled());
4735
break;
4836
}

0 commit comments

Comments
 (0)