Skip to content

Commit 7328987

Browse files
committed
Fixed aria labels in EventTable
1 parent 17642c2 commit 7328987

1 file changed

Lines changed: 12 additions & 10 deletions

File tree

src/EventLogExpert/Components/EventTable.razor

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -7,20 +7,22 @@
77
<table id="eventTable" @onkeydown="HandleKeyDown" role="grid">
88
<thead @oncontextmenu="InvokeTableColumnMenu">
99
<tr role="row">
10-
@foreach (ColumnName column in _enabledColumns)
10+
@for (int columnIndex = 0; columnIndex < _enabledColumns.Length; columnIndex++)
1111
{
12-
_headerName = column.ToFullString();
12+
var columnHeader = _enabledColumns[columnIndex];
13+
_headerName = columnHeader.ToFullString();
1314

14-
<th aria-label="@_headerName" class="@column.ToString().ToLower()" role="columnheader">
15-
@if (column == ColumnName.DateAndTime)
15+
<th aria-colindex="@(columnIndex + 1)" aria-sort="@(_eventTableState.OrderBy == columnHeader ? (_eventTableState.IsDescending ? "descending" : "ascending") : "none")"
16+
class="@columnHeader.ToString().ToLower()" role="columnheader">
17+
@if (columnHeader == ColumnName.DateAndTime)
1618
{
1719
<text>@GetDateColumnHeader()</text>
1820
}
1921
else
2022
{
2123
@_headerName
2224
}
23-
@if (_eventTableState.OrderBy == column)
25+
@if (_eventTableState.OrderBy == columnHeader)
2426
{
2527
<span class="menu-toggle" data-rotate="@_eventTableState.IsDescending.ToString().ToLower()" @onclick="ToggleSorting">
2628
<i class="bi bi-caret-up"></i>
@@ -29,19 +31,19 @@
2931
</th>
3032
}
3133

32-
<th class="description">Description</th>
34+
<th aria-colindex="@(_enabledColumns.Length + 1)" class="description" role="columnheader">Description</th>
3335
</tr>
3436
</thead>
3537
<tbody @oncontextmenu="InvokeContextMenu">
3638
@if (_currentTable is not null)
3739
{
3840
<Virtualize Context="evt" Items="_currentTable.DisplayedEvents">
3941
@{ _rowIndex = _currentTable.DisplayedEvents.IndexOf(evt); }
40-
<tr aria-selected="@_selectedEventState.Contains(evt)" class="@GetCss(evt)" @key="@($"{evt.OwningLog}_{evt.RecordId}")"
41-
@onmousedown="args => SelectEvent(args, evt)" role="row" tabindex="0">
42+
<tr aria-rowindex="@(_rowIndex + 2)" aria-selected="@(_selectedEventState.Contains(evt).ToString().ToLower())"
43+
class="@GetCss(evt)" @key="@($"{evt.OwningLog}_{evt.RecordId}")" @onmousedown="args => SelectEvent(args, evt)" role="row" tabindex="0">
4244
@for (int i = 0; i < _enabledColumns.Length; i++)
4345
{
44-
<td aria-label="Row @(_rowIndex), Column @(i + 1)" role="gridcell">
46+
<td aria-colindex="@(i + 1)" role="gridcell">
4547
@switch (_enabledColumns[i])
4648
{
4749
case ColumnName.Level:
@@ -84,7 +86,7 @@
8486
</td>
8587
}
8688

87-
<td aria-label="Row @(_rowIndex), Column @(_enabledColumns.Length + 1)" role="gridcell">@evt.Description</td>
89+
<td aria-colindex="@(_enabledColumns.Length + 1)" role="gridcell">@evt.Description</td>
8890
</tr>
8991
</Virtualize>
9092
}

0 commit comments

Comments
 (0)