Merge pull request github#21347 from geoffw0/toolstatus

geoffw0 · web-flow · commit ca41ae0d1a9e · 2026-02-20T09:16:44.000Z
Rust: Update rust/diagnostic/database-quality
diff --git a/rust/ql/src/change-notes/2026-02-18-database-quality.md b/rust/ql/src/change-notes/2026-02-18-database-quality.md
@@ -0,0 +1,4 @@
+---
+category: minorAnalysis
+---
+* The macro resolution metric has been removed from `rust/diagnostic/database-quality`. This metric was found to be an unreliable indicator of database quality in many cases, leading to false alarms on the tool status page.
diff --git a/rust/ql/src/queries/telemetry/DatabaseQualityDiagnostics.ql b/rust/ql/src/queries/telemetry/DatabaseQualityDiagnostics.ql
@@ -12,8 +12,6 @@ import codeql.util.Unit
 private predicate diagnostic(string msg, float value, float threshold) {
   CallTargetStatsReport::percentageOfOk(msg, value) and threshold = 50
   or
-  MacroCallTargetStatsReport::percentageOfOk(msg, value) and threshold = 50
-  or
   ExprTypeStatsReport::percentageOfOk(msg, value) and threshold = 20
 }
 

-Original file line number
+Diff line change
@@ @@ -0,0 +1,4 @@ @@
 +---
 +category: minorAnalysis
 +---
 +* The macro resolution metric has been removed from `rust/diagnostic/database-quality`. This metric was found to be an unreliable indicator of database quality in many cases, leading to false alarms on the tool status page.
Original file line number	Diff line number	Diff line change
`@@ -12,8 +12,6 @@ import codeql.util.Unit`
`12`	`12`	`private predicate diagnostic(string msg, float value, float threshold) {`
`13`	`13`	`CallTargetStatsReport::percentageOfOk(msg, value) and threshold = 50`
`14`	`14`	`or`
`15`		`- MacroCallTargetStatsReport::percentageOfOk(msg, value) and threshold = 50`
`16`		`- or`
`17`	`15`	`ExprTypeStatsReport::percentageOfOk(msg, value) and threshold = 20`
`18`	`16`	`}`
`19`	`17`