Skip to content

Commit 559999c

Browse files
committed
Relax JaCoCo coverage thresholds
1 parent 985b5c4 commit 559999c

5 files changed

Lines changed: 12 additions & 17 deletions

File tree

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,6 @@
1515
- Redirected test stdout through Surefire files to keep CI logs compact and review-safe.
1616
- Added repository-level line-ending normalization with `.gitattributes`.
1717
- Expanded the meaningful test baseline to 455 tests across unit/smoke, integration and property categories.
18-
- Raised enforced JaCoCo coverage gates to 91% line, 85% branch and 92% instruction coverage.
18+
- Set enforced JaCoCo coverage gates to 70% line, branch and instruction coverage.
1919
- Reduced SpotBugs debt to zero reported findings with explicit compatibility exclusions for Codewars API names.
2020
- Reduced PMD debt to zero reported findings by removing unused code/imports and simplifying safe expressions.

README.en.md

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -32,14 +32,14 @@ English | [Русский](#русский)
3232
- `src/test/java` — tests and quality suites
3333
- `quality.SmokeSuite` (unit/smoke partition)
3434
- `quality.IntegrationSuite` (transactions scenario tests)
35-
- `quality.PropertySuite` (property-based tests, currently curated)
35+
- `quality.PropertySuite` (curated property-based tests)
3636
- `.github` — CI workflows, dependabot and repo templates
3737
- `ARCHITECTURE.md` — architectural and reviewability notes.
3838
- `CHANGELOG.md`, `CONTRIBUTING.md`, `CODE_OF_CONDUCT.md`, `SECURITY.md`, `TESTING.md` — project governance
3939

4040
### Testing strategy
4141

42-
- **Smoke / Unit baseline** — each kata has direct tests; grouped by `quality.SmokeSuite`.
42+
- **Smoke / Unit tests** — each kata has direct tests; grouped by `quality.SmokeSuite`.
4343
- **Integration** — transaction validation state and ordering, via `quality.IntegrationSuite`.
4444
- **Property-based** — jqwik property tests are grouped in `quality.PropertySuite`.
4545
- **UI tests** — not applicable (`N/A` for this repository, no UI layer).
@@ -55,15 +55,12 @@ English | [Русский](#русский)
5555
- uploaded test and coverage artifacts
5656
- Quality workflow: `.github/workflows/quality.yml`
5757
- runs static checks with `checkstyle`, `pmd`, and `spotbugs` without executing tests
58-
- Checkstyle, PMD and SpotBugs are kept clean in the current quality baseline
59-
- Checkstyle uses a project-specific baseline in `config/checkstyle/checkstyle.xml`
58+
- Checkstyle, PMD and SpotBugs are enforced in the quality gate
59+
- Checkstyle uses project-specific rules in `config/checkstyle/checkstyle.xml`
6060
- Generated smoke wrappers have explicit suppressions in `config/checkstyle/suppressions.xml`
6161
- SpotBugs is kept clean with documented compatibility exceptions in `config/spotbugs-exclude.xml`
6262
- Security workflow: `.github/workflows/codeql-analysis.yml`
6363
- Dependency automation: `.github/dependabot.yml`
64-
- Coverage tracked in JaCoCo + Codecov; the current local baseline is 455 tests with 91.4% line,
65-
85.1% branch and 92.7% instruction coverage.
66-
6764
### Portfolio checklist
6865

6966
- Deterministic implementations with package-localized responsibilities.

README.md

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,11 +44,9 @@
4444
- **Coverage-gate**: JaCoCo ломает `mvn verify`, если покрытие ниже 70% строк, ветвлений
4545
или инструкций.
4646
- **Отдельный quality-гейт**: workflow `.github/workflows/quality.yml` для чистых статических проверок без прогона тестов.
47-
- **Checkstyle / PMD / SpotBugs**: чистый текущий baseline.
47+
- **Checkstyle / PMD / SpotBugs**: статические проверки заведены в quality-гейт.
4848
- **Checkstyle**: проектный набор правил в `config/checkstyle/checkstyle.xml` и явные suppressions для generated smoke-тестов.
4949
- **SpotBugs**: чистый отчёт с явными исключениями совместимости в `config/spotbugs-exclude.xml`.
50-
- **Текущий baseline**: 455 тестов; 91.4% line, 85.1% branch и 92.7% instruction coverage.
51-
5250
### Как запускать
5351

5452
```bash

TESTING.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -61,9 +61,9 @@ mvn -B test -Dtest='quality.PropertySuite'
6161

6262
- Full verification includes tests, JaCoCo reporting/checks and static tools.
6363
- Current enforced JaCoCo minimums:
64-
- line coverage: 91%
65-
- branch coverage: 85%
66-
- instruction coverage: 92%
64+
- line coverage: 70%
65+
- branch coverage: 70%
66+
- instruction coverage: 70%
6767
- Current verified local baseline: 455 tests, 91.4% line coverage,
6868
85.1% branch coverage and 92.7% instruction coverage.
6969
- Run:

pom.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,9 @@
2727
<jqwik.version>1.10.1</jqwik.version>
2828
<junit.platform.version>6.1.0</junit.platform.version>
2929
<lombok.version>1.18.46</lombok.version>
30-
<coverage.line.minimum>0.91</coverage.line.minimum>
31-
<coverage.branch.minimum>0.85</coverage.branch.minimum>
32-
<coverage.instruction.minimum>0.92</coverage.instruction.minimum>
30+
<coverage.line.minimum>0.70</coverage.line.minimum>
31+
<coverage.branch.minimum>0.70</coverage.branch.minimum>
32+
<coverage.instruction.minimum>0.70</coverage.instruction.minimum>
3333
</properties>
3434

3535
<build>

0 commit comments

Comments
 (0)