be able to enable lowercase URL encoding (Compatibility issue with ADFS when validating Signatures

Author: pitbulk

onelogin-saml-sso/php/configuration.php

@@ -145,6 +145,9 @@ function onelogin_saml_configuration() {
 		register_setting($option_group, 'onelogin_saml_advanced_settings_sp_entity_id');
 		add_settings_field('onelogin_saml_advanced_settings_sp_entity_id', __('Service Provider Entity Id', 'onelogin-saml-sso'), "plugin_setting_string_onelogin_saml_advanced_settings_sp_entity_id", $option_group, 'advanced_settings');
 
+		register_setting($option_group, 'onelogin_saml_advanced_idp_lowercase_url_encoding');
+		add_settings_field('onelogin_saml_advanced_idp_lowercase_url_encoding', __('Lowercase URL encoding?', 'onelogin-saml-sso'), "plugin_setting_string_saml_advanced_idp_lowercase_url_encoding", $option_group, 'advanced_settings');
+
 		$mapping_fields = array (
 			'onelogin_saml_advanced_settings_nameid_encrypted' => __('Encrypt nameID', 'onelogin-saml-sso'),
 			'onelogin_saml_advanced_settings_authn_request_signed' => __('Sign AuthnRequest', 'onelogin-saml-sso'),
@@ -197,7 +200,14 @@ function plugin_setting_string_onelogin_saml_idp_x509cert() {
 		echo '</textarea>';
 		echo '<p class="description">'.__('Public x509 certificate of the IdP.  ("X.509 certificate")', 'onelogin-saml-sso');
 	}
-	
+
+	function plugin_setting_string_saml_advanced_idp_lowercase_url_encoding() {
+		$value = get_option('onelogin_saml_advanced_idp_lowercase_url_encoding');
+		echo '<input type="checkbox" name="" id="onelogin_saml_advanced_idp_lowercase_url_encoding"
+			  '.($value ? 'checked="checked"': '').'>'.
+			  '<p class="description">'.__('Some IdPs like ADFS can use lowercase URL encoding, but the plugin expects uppercase URL enconding, enable it to fix incompatibility issues.', 'onelogin-saml-sso').'</p>';
+	}
+
 	function plugin_setting_boolean_onelogin_saml_autocreate() {
 		$value = get_option('onelogin_saml_autocreate');
 		echo '<input type="checkbox" name="onelogin_saml_autocreate" id="onelogin_saml_autocreate"
@@ -283,7 +293,7 @@ function plugin_setting_string_onelogin_saml_role_mapping($role_value) {
 
 	function plugin_setting_string_onelogin_saml_role_order($role_value) {
 		echo '<input type="text" name="onelogin_saml_role_order_'.$role_value.'" id="onelogin_saml_role_order_'.$role_value.'"
-			  value= "'.get_option('onelogin_saml_role_order_'.$role_value).'" size="5">';
+			  value= "'.get_option('onelogin_saml_role_order_'.$role_value).'" size="3">';
 	}
 
 	function plugin_setting_boolean_onelogin_saml_role_mapping_multivalued_in_one_attribute_value() {

onelogin-saml-sso/php/settings.php

@@ -86,6 +86,7 @@
             'url' => get_option('onelogin_saml_idp_slo'),
         ),
         'x509cert' => get_option('onelogin_saml_idp_x509cert'),
+        'lowercaseUrlencoding' => get_option('onelogin_saml_advanced_idp_lowercase_url_encoding', false),
     ),
 
     'security' => array (