Skip to content

Commit 8889ad1

Browse files
author
Jorrin
committed
fix: pr feedback
1 parent 77b424d commit 8889ad1

File tree

7 files changed

+142
-139
lines changed

7 files changed

+142
-139
lines changed

packages/openapi-ts-tests/main/test/__snapshots__/2.0.x/plugins/@tanstack/react-query/responseStyle/@tanstack/react-query.gen.ts

Lines changed: 34 additions & 34 deletions
Large diffs are not rendered by default.

packages/openapi-ts-tests/main/test/__snapshots__/3.0.x/plugins/@tanstack/react-query/responseStyle/@tanstack/react-query.gen.ts

Lines changed: 49 additions & 49 deletions
Large diffs are not rendered by default.

packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/plugins/@tanstack/react-query/responseStyle/@tanstack/react-query.gen.ts

Lines changed: 49 additions & 49 deletions
Large diffs are not rendered by default.

packages/openapi-ts/src/plugins/@tanstack/query-core/v5/infiniteQueryOptions.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,8 @@ export const createInfiniteQueryOptions = ({
181181

182182
if (plugin.config.responseStyle === 'fields') {
183183
// --- 'fields' code path: TStyle generic, ResponseResult/ResponseError wrappers ---
184-
const defaultStyle = plugin.config.responseStyle;
184+
// Default to 'data' so omitting responseStyle preserves backward-compatible behavior
185+
const defaultStyle = 'data' as const;
185186

186187
const symbolResponseResult = plugin.referenceSymbol({
187188
category: 'type',

packages/openapi-ts/src/plugins/@tanstack/query-core/v5/mutationOptions.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,8 @@ export const createMutationOptions = ({
3333

3434
if (plugin.config.responseStyle === 'fields') {
3535
// --- 'fields' code path: TStyle generic, ResponseResult/ResponseError wrappers ---
36-
const defaultStyle = plugin.config.responseStyle;
36+
// Default to 'data' so omitting responseStyle preserves backward-compatible behavior
37+
const defaultStyle = 'data' as const;
3738

3839
const symbolResponseResult = plugin.referenceSymbol({
3940
category: 'type',
@@ -178,7 +179,7 @@ export const createMutationOptions = ({
178179
},
179180
);
180181
const statement = $.const(symbolMutationOptions)
181-
.export()
182+
.export(plugin.config.mutationOptions.exported)
182183
.$if(plugin.config.comments && createOperationComment(operation), (c, v) => c.doc(v))
183184
.assign(
184185
$.func()

packages/openapi-ts/src/plugins/@tanstack/query-core/v5/plugin.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import ts from 'typescript';
22

3-
import { TsDsl } from '../../../../ts-dsl';
4-
import { $ } from '../../../../ts-dsl';
3+
import { $, TsDsl } from '../../../../ts-dsl';
54
import type { PluginHandler, PluginInstance } from '../types';
65
import { createInfiniteQueryOptions } from './infiniteQueryOptions';
76
import { createMutationOptions } from './mutationOptions';
@@ -168,7 +167,8 @@ export const handlerV5: PluginHandler = ({ plugin }) => {
168167

169168
// Generate ResponseResult and ResponseError utility types only when responseStyle is 'fields'
170169
if (plugin.config.responseStyle === 'fields') {
171-
createResponseStyleTypes(plugin.config.responseStyle, plugin);
170+
// Default to 'data' so omitting responseStyle preserves backward-compatible behavior
171+
createResponseStyleTypes('data', plugin);
172172
}
173173

174174
plugin.forEach(

packages/openapi-ts/src/plugins/@tanstack/query-core/v5/queryOptions.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,8 @@ export const createQueryOptions = ({
6060

6161
if (plugin.config.responseStyle === 'fields') {
6262
// --- 'fields' code path: TStyle generic, ResponseResult/ResponseError wrappers ---
63-
const defaultStyle = plugin.config.responseStyle;
63+
// Default to 'data' so omitting responseStyle preserves backward-compatible behavior
64+
const defaultStyle = 'data' as const;
6465

6566
const symbolResponseResult = plugin.referenceSymbol({
6667
category: 'type',

0 commit comments

Comments
 (0)