test(poller): cover enhanced rate-limit protection

Author: hesreallyhim

REFACTOR-PLAN.md

@@ -259,6 +259,10 @@ describe('fetchRateLimit', () => {
       ok: false,
       status: 401,
       statusText: 'Unauthorized',
+      text: vi.fn().mockResolvedValue(''),
+      headers: {
+        get: vi.fn().mockReturnValue(null),
+      },
     };
     const mockFetch = vi.fn().mockResolvedValue(mockResponse);
     vi.stubGlobal('fetch', mockFetch);
@@ -272,6 +276,38 @@ describe('fetchRateLimit', () => {
     }
   });
 
+  it('captures rate limit headers and message for 429 responses', async () => {
+    const headerMap = new Map([
+      ['x-ratelimit-remaining', '0'],
+      ['x-ratelimit-reset', '1706203600'],
+      ['retry-after', '45'],
+    ]);
+
+    const mockResponse = {
+      ok: false,
+      status: 429,
+      statusText: 'Too Many Requests',
+      text: vi.fn().mockResolvedValue(JSON.stringify({ message: 'Secondary rate limit exceeded' })),
+      headers: {
+        get: (name: string) => headerMap.get(name) ?? null,
+      },
+    };
+    const mockFetch = vi.fn().mockResolvedValue(mockResponse);
+    vi.stubGlobal('fetch', mockFetch);
+
+    const result = await fetchRateLimit('test-token');
+
+    expect(result.success).toBe(false);
+    if (!result.success) {
+      expect(result.error).toContain('HTTP 429');
+      expect(result.rate_limit?.status).toBe(429);
+      expect(result.rate_limit?.rate_limit_remaining).toBe(0);
+      expect(result.rate_limit?.rate_limit_reset).toBe(1706203600);
+      expect(result.rate_limit?.retry_after_seconds).toBe(45);
+      expect(result.rate_limit?.message).toContain('Secondary rate limit exceeded');
+    }
+  });
+
   it('passes abort signal to fetch', async () => {
     // Mock fetch to capture the signal
     let capturedSignal: AbortSignal | undefined;

test/github.test.ts

@@ -26,9 +26,11 @@ function makeState(overrides: Partial<ReducerState> = {}): ReducerState {
     buckets: {},
     started_at_ts: '2026-01-25T12:00:00.000Z',
     stopped_at_ts: '2026-01-25T12:10:00.000Z',
+    poller_started_at_ts: null,
     interval_seconds: 30,
     poll_count: 20,
     poll_failures: 0,
+    secondary_rate_limit_hits: 0,
     last_error: null,
     ...overrides,
   };
@@ -346,6 +348,15 @@ describe('generateWarnings', () => {
     expect(warnings).toContainEqual(expect.stringContaining('3 anomaly'));
   });
 
+  it('warns on secondary rate limit hits', () => {
+    const state = makeState({ secondary_rate_limit_hits: 2 });
+    const warnings = generateWarnings(state);
+
+    expect(warnings).toContainEqual(
+      expect.stringContaining('Secondary rate limit warning response was received (2 times)'),
+    );
+  });
+
   it('warns on multiple window crosses for active buckets', () => {
     const baseBucket = {
       last_reset: 1706230800,

test/output.test.ts

@@ -15,6 +15,8 @@ export function makeBucket(overrides: Partial<BucketState> = {}): BucketState {
     last_seen_ts: '2025-01-25T12:00:00Z',
     limit: 5000,
     remaining: 5000,
+    first_used: 0,
+    first_remaining: 5000,
     ...overrides,
   };
 }
@@ -28,6 +30,7 @@ export function makeState(buckets: Record<string, BucketState> = {}): ReducerSta
     interval_seconds: POLL_INTERVAL_SECONDS,
     poll_count: 5,
     poll_failures: 0,
+    secondary_rate_limit_hits: 0,
     last_error: null,
   };
 }

test/poller/helpers.ts

@@ -5,7 +5,13 @@
  */
 
 import { describe, it, expect, vi, beforeEach, afterEach, type MockInstance } from 'vitest';
-import { main, createShutdownHandler, isDiagnosticsEnabled, runPollerLoop } from '../../src/poller';
+import {
+  main,
+  createShutdownHandler,
+  isDiagnosticsEnabled,
+  runPollerLoop,
+  createRateLimitControlState,
+} from '../../src/poller';
 import type { LoopDeps } from '../../src/poller';
 import type { ReducerState } from '../../src/types';
 import { MAX_LIFETIME_MS } from '../../src/types';
@@ -184,6 +190,10 @@ describe('runPollerLoop', () => {
     };
   }
 
+  function makePollSuccess(state: ReducerState) {
+    return { success: true as const, state, control_state: createRateLimitControlState() };
+  }
+
   /** Creates deps that exit via MAX_LIFETIME_MS after `exitAfterNowCalls` calls to `deps.now`. */
   function makeTimedDeps(exitAfterNowCalls: number, overrides?: Partial<LoopDeps>): LoopDeps {
     let nowCallCount = 0;
@@ -192,7 +202,7 @@ describe('runPollerLoop', () => {
         nowCallCount++;
         return nowCallCount >= exitAfterNowCalls ? MAX_LIFETIME_MS : 0;
       }),
-      performPoll: vi.fn().mockResolvedValue(makeState()),
+      performPoll: vi.fn().mockResolvedValue(makePollSuccess(makeState())),
       ...overrides,
     });
   }
@@ -248,7 +258,7 @@ describe('runPollerLoop', () => {
     const deps = makeTimedDeps(3, {
       performPoll: vi.fn().mockImplementation(() => {
         pollCallCount++;
-        if (pollCallCount === 1) return Promise.resolve(makeState());
+        if (pollCallCount === 1) return Promise.resolve(makePollSuccess(makeState()));
         return Promise.reject(new Error('network failure'));
       }),
     });
@@ -292,7 +302,7 @@ describe('runPollerLoop', () => {
         if (nowCallCount <= 3) return nowMs;
         return nowMs + MAX_LIFETIME_MS; // triggers lifetime exit
       }),
-      performPoll: vi.fn().mockResolvedValue(burstState),
+      performPoll: vi.fn().mockResolvedValue(makePollSuccess(burstState)),
     });
 
     await runPollerLoop('token', 30, false, deps);