Utilizing sanic 0.4 testing capabilities

Author: grazor

setup.py

@@ -1,6 +1,6 @@
 from setuptools import setup, find_packages
 
-required_packages = ['graphql-core>=1.0', 'sanic>=0.3.1', 'pytest-runner']
+required_packages = ['graphql-core>=1.0', 'sanic>=0.4.0', 'pytest-runner']
 
 setup(
     name='Sanic-GraphQL',

tests/app.py

@@ -1,6 +1,12 @@
 from functools import partial
 
+try:
+    from urllib import urlencode
+except ImportError:
+    from urllib.parse import urlencode
+
 from sanic import Sanic
+from sanic.testing import TestClient
 from sanic_graphql import GraphQLView
 from graphql.execution.executors.asyncio import AsyncioExecutor
 
@@ -15,20 +21,26 @@ def create_app(path='/graphql', **kwargs):
     async_executor = kwargs.pop('async_executor', False)
 
     if async_executor:
+        @app.listener('before_server_start')
         def init_async_executor(app, loop):
             executor = AsyncioExecutor(loop)
             app.add_route(GraphQLView.as_view(schema=schema, executor=executor, **kwargs), path)
 
+        @app.listener('before_server_stop')
         def remove_graphql_endpoint(app, loop):
             app.remove_route(path)
-
-        app.server_kwargs = dict(
-            before_start=init_async_executor,
-            after_stop=remove_graphql_endpoint
-        )
     else:
         app.add_route(GraphQLView.as_view(schema=schema, **kwargs), path)
-        app.server_kwargs = dict()
 
+    app.client = TestClient(app)
     return app
 
+
+def url_string(uri='/graphql', **url_params):
+    string = '/graphql'
+
+    if url_params:
+        string += '?' + urlencode(url_params)
+
+    return string
+

tests/test_graphiqlview.py

@@ -2,8 +2,7 @@
 
 from jinja2 import Environment
 
-from .app import create_app
-from .util import app, client, url_string
+from .app import create_app, url_string
 
 
 @pytest.fixture
@@ -21,17 +20,17 @@ def pretty_response():
     (create_app(async_executor=False, graphiql=True)),
     (create_app(async_executor=True, graphiql=True)),
 ])
-def test_graphiql_is_enabled(app, client):
-    response = client.get(app,  uri=url_string(), headers={'Accept': 'text/html'})
+def test_graphiql_is_enabled(app):
+    _, response = app.client.get( uri=url_string(), headers={'Accept': 'text/html'})
     assert response.status == 200
 
 
 @pytest.mark.parametrize('app', [
     (create_app(async_executor=False, graphiql=True)),
     (create_app(async_executor=True, graphiql=True)),
 ])
-def test_graphiql_simple_renderer(app, client, pretty_response):
-    response = client.get(app, uri=url_string(query='{test}'), headers={'Accept': 'text/html'})
+def test_graphiql_simple_renderer(app, pretty_response):
+    _, response = app.client.get(uri=url_string(query='{test}'), headers={'Accept': 'text/html'})
     assert response.status == 200
     assert pretty_response in response.body.decode('utf-8')
 
@@ -40,8 +39,8 @@ def test_graphiql_simple_renderer(app, client, pretty_response):
     (create_app(async_executor=False, graphiql=True, jinja_env=Environment())),
     (create_app(async_executor=True, graphiql=True, jinja_env=Environment())),
 ])
-def test_graphiql_jinja_renderer(app, client, pretty_response):
-    response = client.get(app, uri=url_string(query='{test}'), headers={'Accept': 'text/html'})
+def test_graphiql_jinja_renderer(app, pretty_response):
+    _, response = app.client.get(uri=url_string(query='{test}'), headers={'Accept': 'text/html'})
     assert response.status == 200
     assert pretty_response in response.body.decode('utf-8')
 
@@ -50,8 +49,8 @@ def test_graphiql_jinja_renderer(app, client, pretty_response):
     (create_app(async_executor=False, graphiql=True, jinja_env=Environment(enable_async=True))),
     (create_app(async_executor=True, graphiql=True, jinja_env=Environment(enable_async=True))),
 ])
-def test_graphiql_jinja_async_renderer(app, client, pretty_response):
-    response = client.get(app, uri=url_string(query='{test}'), headers={'Accept': 'text/html'})
+def test_graphiql_jinja_async_renderer(app, pretty_response):
+    _, response = app.client.get(uri=url_string(query='{test}'), headers={'Accept': 'text/html'})
     assert response.status == 200
     assert pretty_response in response.body.decode('utf-8')
 
@@ -60,6 +59,6 @@ def test_graphiql_jinja_async_renderer(app, client, pretty_response):
     (create_app(async_executor=False, graphiql=True, jinja_env=Environment())),
     (create_app(async_executor=True, graphiql=True, jinja_env=Environment())),
 ])
-def test_graphiql_html_is_not_accepted(app, client):
-    response = client.get(app, uri=url_string(), headers={'Accept': 'application/json'})
+def test_graphiql_html_is_not_accepted(app):
+    _, response = app.client.get(uri=url_string(), headers={'Accept': 'application/json'})
     assert response.status == 400