Remove error handling for now

Author: marcnjaramillo

extensions/ql-vscode/src/cli.ts

@@ -4,7 +4,6 @@ import * as fs from 'fs-extra';
 import * as path from 'path';
 import { parser } from 'stream-json';
 import { pick } from 'stream-json/filters/Pick';
-import { verifier } from 'stream-json/utils/Verifier';
 import Assembler = require('stream-json/Assembler');
 import { chain } from 'stream-chain';
 import * as sarif from 'sarif';
@@ -591,18 +590,14 @@ export class CodeQLCliServer implements Disposable {
         fs.createReadStream(interpretedResultsPath),
         p,
         pick({filter: 'runs.0.results'}),
-        verifier()
       ]);
 
       // Creates JavaScript objects from the token stream
       const asm = Assembler.connectTo(pipeline);
 
       // Returns a constructed Log object with the results or an empty array if no results were found.
       // If the parser fails for any reason, it will reject the promise.
-      return await new Promise((resolve, reject) => {
-        pipeline.on('error', (error) => {
-          reject(error);
-        });
+      return await new Promise((resolve) => {
 
         asm.on('done', (asm) => {
 

extensions/ql-vscode/src/vscode-tests/no-workspace/cli.test.ts

@@ -14,11 +14,6 @@ describe.only('cliServerTests', () => {
 
   it('should return an empty array if there are no results', async () => {
     const result = await CodeQLCliServer.parseSarif(__dirname + '/data/sarif/emptyResultsSarif.sarif');
-    expect(result.runs[0].results?.length).to.eq(0);
-  });
-
-  it('should throw an error if the file fails to parse', async () => {
-    const result = await CodeQLCliServer.parseSarif(__dirname + '/data/sarif/invalidSarif.sarif');
-    await expect(result).to.rejectedWith(/Error: Parsing output of interpretation failed: /);
+    expect(result.runs[0].results).to.be.empty;
   });
 });

extensions/ql-vscode/src/vscode-tests/no-workspace/data/sarif/emptyResultsSarif.sarif

@@ -28,7 +28,7 @@
           }
         }
       ],
-      "results": [],
+      "results": []
       ]
     }
   ]