Fix import + throw error

Author: shati-patel

extensions/ql-vscode/src/packaging.ts

@@ -3,7 +3,6 @@ import {
   getOnDiskWorkspaceFolders,
   showAndLogErrorMessage,
   showAndLogInformationMessage,
-  showAndLogWarningMessage,
 } from './helpers';
 import { QuickPickItem, window } from 'vscode';
 import { ProgressCallback, UserCancellationException } from './commandRunner';
@@ -123,8 +122,8 @@ export async function handleInstallPacks(
     }
     if (failedPacks.length > 0) {
       void logger.log(`Errors:\n${errors.join('\n')}`);
-      void showAndLogWarningMessage(
-        `Unable to install some packs: ${failedPacks.join(', ')}. See logs for more details.`
+      throw new Error(
+        `Unable to install packs: ${failedPacks.join(', ')}. See logs for more details.`
       );
     } else {
       void showAndLogInformationMessage('Finished installing packs.');

extensions/ql-vscode/src/vscode-tests/cli-integration/packaging.test.ts

@@ -47,7 +47,7 @@ describe('Packaging commands', function() {
     showAndLogErrorMessageSpy = sandbox.stub();
     showAndLogInformationMessageSpy = sandbox.stub();
     mod = proxyquire('../../packaging', {
-      '../helpers': {
+      './helpers': {
         showAndLogErrorMessage: showAndLogErrorMessageSpy,
         showAndLogInformationMessage: showAndLogInformationMessageSpy,
       },