Skip to content

Commit 8e156d6

Browse files
Apply suggestions from code review
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com>
1 parent dfcaa27 commit 8e156d6

1 file changed

Lines changed: 1 addition & 2 deletions

File tree

extensions/ql-vscode/src/run-queries.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ export class QueryInfo {
9595

9696
const callbackId = qs.registerCallback(res => { result = res; });
9797

98-
const availableMlModelUris: messages.MlModel[] = availableMlModels.map(model => ({ uri: Uri.file(model.path).toString() }));
98+
const availableMlModelUris: messages.MlModel[] = availableMlModels.map(model => ({ uri: Uri.file(model.path).toString(true) }));
9999

100100
const queryToRun: messages.QueryToRun = {
101101
resultsPath: this.resultsPaths.resultsPath,
@@ -630,7 +630,6 @@ export async function compileAndRunQueryAgainstDatabase(
630630
} catch (e) {
631631
const message = `Couldn't resolve available ML models for ${qlProgram.queryPath}. Running the ` +
632632
`query without any ML models: ${e}.`;
633-
void logger.log(message);
634633
void showAndLogErrorMessage(message);
635634
}
636635
}

0 commit comments

Comments
 (0)