Add separate tests for valid/invalid pack install

Author: shati-patel

extensions/ql-vscode/src/packaging.ts

@@ -123,7 +123,7 @@ export async function handleInstallPacks(
     if (failedPacks.length > 0) {
       void logger.log(`Errors:\n${errors.join('\n')}`);
       throw new Error(
-        `Unable to install packs: ${failedPacks.join(', ')}. See logs for more details.`
+        `Unable to install packs: ${failedPacks.join(', ')}. See log for more details.`
       );
     } else {
       void showAndLogInformationMessage('Finished installing packs.');

extensions/ql-vscode/src/vscode-tests/cli-integration/data-invalid-pack/qlpack.yml

@@ -0,0 +1,4 @@
+name: foo/bar
+version: 0.0.0
+dependencies:
+  foo/baz: '*'

extensions/ql-vscode/src/vscode-tests/cli-integration/packaging.test.ts

@@ -77,7 +77,7 @@ describe('Packaging commands', function() {
     );
   });
 
-  it('should show error for invalid user-specified pack', async () => {
+  it('should show error when downloading invalid user-specified pack', async () => {
     quickPickSpy.resolves('Download custom specified pack');
     inputBoxSpy.resolves('foo/not-a-real-pack@0.0.1');
 
@@ -88,7 +88,7 @@ describe('Packaging commands', function() {
     );
   });
 
-  it('should attempt to install selected workspace packs', async () => {
+  it('should install valid workspace pack', async () => {
     const rootDir = path.join(__dirname, '../../../src/vscode-tests/cli-integration/data');
     quickPickSpy.resolves([
       {
@@ -97,11 +97,26 @@ describe('Packaging commands', function() {
       },
     ]);
 
+    await mod.handleInstallPacks(cli, progress);
+    expect(showAndLogInformationMessageSpy.firstCall.args[0]).to.contain(
+      'Finished installing packs.'
+    );
+  });
+
+  it('should throw an error when installing invalid workspace pack', async () => {
+    const rootDir = path.join(__dirname, '../../../src/vscode-tests/cli-integration/data-invalid-pack');
+    quickPickSpy.resolves([
+      {
+        label: 'foo/bar',
+        packRootDir: [rootDir],
+      },
+    ]);
+
     try {
+      // expect this to throw an error
       await mod.handleInstallPacks(cli, progress);
-      expect(showAndLogInformationMessageSpy.firstCall.args[0]).to.contain(
-        'Finished installing packs.'
-      );
+      // This line should not be reached
+      expect(true).to.be.false;
     } catch (error) {
       expect(error.message).to.contain('Unable to install packs:');
     }