Dont bubble up an error for getClient

omgitsads · omgitsads · commit cd77c136c1d5 · 2025-11-18T16:30:28.000+01:00
We should do this eventually, but to keep the existing behavior, we
just return the error to the client.
diff --git a/pkg/github/context_tools.go b/pkg/github/context_tools.go
@@ -47,7 +47,7 @@ func GetMe(getClient GetClientFn, t translations.TranslationHelperFunc) (mcp.Too
 		mcp.ToolHandlerFor[map[string]any, any](func(ctx context.Context, _ *mcp.CallToolRequest, _ map[string]any) (*mcp.CallToolResult, any, error) {
 			client, err := getClient(ctx)
 			if err != nil {
-				return utils.NewToolResultErrorFromErr("failed to get GitHub client", err), nil, err
+				return utils.NewToolResultErrorFromErr("failed to get GitHub client", err), nil, nil
 			}
 
 			user, res, err := client.Users.Get(ctx, "")

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ func GetMe(getClient GetClientFn, t translations.TranslationHelperFunc) (mcp.Too`
`47`	`47`	`mcp.ToolHandlerFor[map[string]any, any](func(ctx context.Context, _ mcp.CallToolRequest, _ map[string]any) (mcp.CallToolResult, any, error) {`
`48`	`48`	`client, err := getClient(ctx)`
`49`	`49`	`if err != nil {`
`50`		`- return utils.NewToolResultErrorFromErr("failed to get GitHub client", err), nil, err`
	`50`	`+ return utils.NewToolResultErrorFromErr("failed to get GitHub client", err), nil, nil`
`51`	`51`	`}`
`52`	`52`
`53`	`53`	`user, res, err := client.Users.Get(ctx, "")`