Skip to content

Commit f07cbfd

Browse files
Copilotlpcox
andauthored
fix: address config debug logging review feedback
Agent-Logs-Url: https://github.com/github/gh-aw-mcpg/sessions/14d88f97-3dd7-4220-8f4f-f53f53e0e15d Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
1 parent 313a403 commit f07cbfd

1 file changed

Lines changed: 9 additions & 3 deletions

File tree

internal/config/config_core.go

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -260,7 +260,7 @@ func applyGatewayDefaults(cfg *GatewayConfig) {
260260
if cfg.KeepaliveInterval == 0 {
261261
cfg.KeepaliveInterval = DefaultKeepaliveInterval
262262
}
263-
logConfig.Printf("Applied gateway defaults: port=%d, startupTimeout=%d, toolTimeout=%d, keepaliveInterval=%d",
263+
logConfig.Printf("Resolved gateway config after defaulting: port=%d, startupTimeout=%d, toolTimeout=%d, keepaliveInterval=%d",
264264
cfg.Port, cfg.StartupTimeout, cfg.ToolTimeout, cfg.KeepaliveInterval)
265265
}
266266

@@ -373,7 +373,13 @@ func LoadFromFile(path string) (*Config, error) {
373373
}
374374

375375
// Validate TOML stdio servers use Docker for containerization (Spec Section 3.2.1)
376-
logConfig.Printf("Validating stdio server containerization requirements for %d servers", len(cfg.Servers))
376+
stdioServerCount := 0
377+
for _, serverCfg := range cfg.Servers {
378+
if serverCfg.Type == "stdio" {
379+
stdioServerCount++
380+
}
381+
}
382+
logConfig.Printf("Validating stdio server containerization requirements for %d stdio servers", stdioServerCount)
377383
if err := validateTOMLStdioContainerization(cfg.Servers); err != nil {
378384
return nil, err
379385
}
@@ -402,7 +408,7 @@ func LoadFromFile(path string) (*Config, error) {
402408
// Merge opentelemetry key into tracing when present (spec §4.1.3.6).
403409
// opentelemetry takes precedence over the legacy tracing key.
404410
if cfg.Gateway.Opentelemetry != nil {
405-
logConfig.Printf("opentelemetry section found: merging into tracing config, endpoint=%s", cfg.Gateway.Opentelemetry.Endpoint)
411+
logConfig.Printf("opentelemetry section found: merging into tracing config (endpoint_set=%t)", cfg.Gateway.Opentelemetry.Endpoint != "")
406412
cfg.Gateway.Tracing = cfg.Gateway.Opentelemetry
407413
cfg.Gateway.Opentelemetry = nil
408414
// Expand ${VAR} expressions in tracing fields before validation.

0 commit comments

Comments
 (0)