Skip to content

Commit e276b07

Browse files
Copilotlpcox
andauthored
Update launcher comment to clarify defensive fallback nature of OIDC check
Agent-Logs-Url: https://github.com/github/gh-aw-mcpg/sessions/b2ecfab2-61b7-47ed-b0ab-6a60c21cffd0 Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
1 parent ab6f8ee commit e276b07

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

internal/launcher/launcher.go

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -72,9 +72,10 @@ func New(ctx context.Context, cfg *config.Config) *Launcher {
7272
logger.LogInfo("startup", "GitHub Actions OIDC provider initialized")
7373
}
7474

75-
// Pre-populate serverErrors for OIDC-misconfigured servers so /health
76-
// reports them as "error" immediately at startup, not only after the
77-
// first failed request.
75+
// Defensive fallback: pre-populate serverErrors for OIDC-misconfigured servers
76+
// so /health reports them as "error" immediately at startup. Normal config
77+
// validation (validateAuthConfig) catches this earlier; this handles cases
78+
// where validation was bypassed (e.g., tests constructing configs manually).
7879
serverErrors := make(map[string]string)
7980
for serverID, serverCfg := range cfg.Servers {
8081
if serverCfg.Auth != nil && serverCfg.Auth.Type == "github-oidc" && oidcProvider == nil {

0 commit comments

Comments
 (0)