test: address review feedback for safe type assertions

Agent-Logs-Url: https://github.com/github/gh-aw-mcpg/sessions/5e78a2b2-2590-435f-9662-ff17be3389fd

Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>

Author: Copilot

internal/config/config_test.go

@@ -1089,7 +1089,7 @@ port 3000
 	errMsg := err.Error()
 	assert.Contains(t, errMsg, "line", "Error should mention line number")
 	// Our improved format includes "column" explicitly when ParseError is detected
-	assert.Regexp(t, `column|line 2`, errMsg,
+	assert.Regexp(t, `\bcolumn\b|\bline\s+2\b`, errMsg,
 		"Error should mention column or line position, got: %s", errMsg)
 }
 

internal/config/fetch_and_fix_schema_test.go

@@ -245,7 +245,10 @@ func TestFixSchemaBytes_AddRegistryAndGuardPoliciesToStdioConfig(t *testing.T) {
 	require.True(t, hasGuardPolicies, "guard-policies field should be added to stdioServerConfig.properties")
 	gpMap := guardPolicies.(map[string]interface{})
 	assert.Equal(t, "object", gpMap["type"], "guard-policies.type should be 'object'")
-	assert.True(t, gpMap["additionalProperties"].(bool), "guard-policies.additionalProperties should be true")
+	additionalProperties, hasAdditionalProperties := gpMap["additionalProperties"]
+	require.True(t, hasAdditionalProperties, "guard-policies.additionalProperties should be present")
+	require.IsType(t, true, additionalProperties, "guard-policies.additionalProperties should be a bool")
+	assert.True(t, additionalProperties.(bool), "guard-policies.additionalProperties should be true")
 }
 
 // TestFixSchemaBytes_AddRegistryAndGuardPoliciesToHttpConfig covers the injection

internal/mcp/tool_result_test.go

@@ -268,7 +268,9 @@ func TestParseToolArguments(t *testing.T) {
 		require.NotNil(t, args)
 		assert.Equal(t, "search term", args["query"])
 		assert.Equal(t, float64(10), args["limit"])
-		assert.True(t, args["active"].(bool))
+		active, ok := args["active"].(bool)
+		require.True(t, ok, "expected active to be a bool")
+		assert.True(t, active)
 	})
 
 	t.Run("nested object arguments are parsed correctly", func(t *testing.T) {

internal/mcp/unmarshal_params_test.go

@@ -153,7 +153,9 @@ func TestUnmarshalParams(t *testing.T) {
 		// JSON unmarshal converts numbers to float64 by default
 		assert.Equal(t, float64(42), target["int_val"])
 		assert.Equal(t, 3.14, target["float_val"])
-		assert.True(t, target["bool_val"].(bool))
+		boolVal, ok := target["bool_val"].(bool)
+		require.True(t, ok, "bool_val should be a bool")
+		assert.True(t, boolVal)
 		assert.Len(t, target["array_val"], 3)
 		assert.NotNil(t, target["object_val"])
 		assert.Nil(t, target["null_val"])

internal/proxy/proxy_test.go

@@ -682,7 +682,11 @@ func TestRewrapSearchResponse(t *testing.T) {
 		result := rewrapSearchResponse(original, filtered)
 		m := result.(map[string]interface{})
 		assert.Equal(t, float64(2), m["total_count"])
-		assert.False(t, m["incomplete_results"].(bool))
+		incompleteResults, ok := m["incomplete_results"]
+		require.True(t, ok)
+		incompleteResultsBool, ok := incompleteResults.(bool)
+		require.True(t, ok)
+		assert.False(t, incompleteResultsBool)
 		assert.Len(t, m["items"].([]interface{}), 2)
 	})