[Repo Assist] test(mcp): add connect-timeout default behaviour tests (#3947)

🤖 *This is a Repo Assist automated pull request.*

## Summary

Adds four white-box tests in `package mcp` to cover the `connectTimeout`
defaulting behaviour in `NewHTTPConnection`.

These tests were motivated by the bug in #3933 (inconsistent `== 0`
guard in `reconnectSDKTransport`) and serve as regression guards for
both fixes.

## Tests Added

| Test | What it checks |
|------|---------------|
| `TestNewHTTPConnection_DefaultConnectTimeout_ZeroInput` |
`connectTimeout=0` → stored as `defaultConnectTimeout` (30 s) |
| `TestNewHTTPConnection_DefaultConnectTimeout_NegativeInput` |
`connectTimeout=-1s` → stored as `defaultConnectTimeout` (guards the `<=
0` fix) |
| `TestNewHTTPConnection_DefaultConnectTimeout_CustomValue` |
`connectTimeout=10s` → stored unchanged |
| `TestDefaultConnectTimeout_Value` | `defaultConnectTimeout ==
30*time.Second` — prevents silent drift from
`config.DefaultConnectTimeout` |

## Implementation notes

- Tests are in `package mcp` (white-box, same as existing
`http_connection_test.go`) to allow direct access to the unexported
`conn.connectTimeout` field.
- A shared `newMinimalTestServer` helper constructs the httptest server
needed for `NewHTTPConnection` to complete its handshake.

## Test Status

⚠️ **Infrastructure constraint**: `proxy.golang.org` is blocked in this
environment, preventing `go test` from running locally. The tests follow
the same pattern as the existing `http_connection_test.go` tests and are
written to pass against the companion fix PR
(`repo-assist/fix-issue-3933-connect-timeout`).




> [!WARNING]
> <details>
> <summary><strong>⚠️ Firewall blocked 1 domain</strong></summary>
>
> The following domain was blocked by the firewall during workflow
execution:
>
> - `proxy.golang.org`
>
> To allow these domains, add them to the `network.allowed` list in your
workflow frontmatter:
>
> ```yaml
> network:
>   allowed:
>     - defaults
>     - "proxy.golang.org"
> ```
>
> See [Network
Configuration](https://github.github.com/gh-aw/reference/network/) for
more information.
>
> </details>


> Generated by [Repo
Assist](https://github.com/github/gh-aw-mcpg/actions/runs/24510723428/agentic_workflow)
· ● 6.1M ·
[◷](https://github.com/search?q=repo%3Agithub%2Fgh-aw-mcpg+%22gh-aw-workflow-id%3A+repo-assist%22&type=pullrequests)
>
> To install this [agentic
workflow](https://github.com/githubnext/agentics/blob/851905c06e905bf362a9f6cc54f912e3df747d55/workflows/repo-assist.md),
run
> ```
> gh aw add
githubnext/agentics@851905c
> ```

<!-- gh-aw-agentic-workflow: Repo Assist, engine: copilot, model: auto,
id: 24510723428, workflow_id: repo-assist, run:
https://github.com/github/gh-aw-mcpg/actions/runs/24510723428 -->

<!-- gh-aw-workflow-id: repo-assist -->

Author: lpcox

internal/mcp/connect_timeout_test.go

@@ -0,0 +1,100 @@
+package mcp
+
+import (
+	"context"
+	"encoding/json"
+	"net/http"
+	"net/http/httptest"
+	"testing"
+	"time"
+
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+)
+
+// newMinimalTestServer returns an httptest server that responds with the
+// minimal HTTP semantics needed for NewHTTPConnection to complete its SDK
+// transport handshake reliably.
+func newMinimalTestServer(t *testing.T) *httptest.Server {
+	t.Helper()
+	return httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+		switch r.Method {
+		case http.MethodGet:
+			w.Header().Set("Content-Type", "text/event-stream")
+			w.WriteHeader(http.StatusOK)
+			return
+		case http.MethodPost:
+			resp := map[string]interface{}{
+				"jsonrpc": "2.0",
+				"id":      1,
+				"result": map[string]interface{}{
+					"protocolVersion": "2024-11-05",
+					"serverInfo":      map[string]interface{}{"name": "test"},
+				},
+			}
+			w.Header().Set("Content-Type", "application/json")
+			w.Header().Set("Mcp-Session-Id", "test-session")
+			json.NewEncoder(w).Encode(resp) //nolint:errcheck
+			return
+		default:
+			w.WriteHeader(http.StatusMethodNotAllowed)
+			return
+		}
+	}))
+}
+
+// TestNewHTTPConnection_DefaultConnectTimeout_ZeroInput verifies that a zero
+// connectTimeout is replaced with defaultConnectTimeout (30 s).
+func TestNewHTTPConnection_DefaultConnectTimeout_ZeroInput(t *testing.T) {
+	srv := newMinimalTestServer(t)
+	defer srv.Close()
+
+	conn, err := NewHTTPConnection(context.Background(), "test", srv.URL,
+		map[string]string{"Authorization": "test"}, nil, "", 0, 0)
+	require.NoError(t, err)
+	require.NotNil(t, conn)
+	defer conn.Close()
+
+	assert.Equal(t, defaultConnectTimeout, conn.connectTimeout,
+		"zero connectTimeout should be replaced with defaultConnectTimeout")
+}
+
+// TestNewHTTPConnection_DefaultConnectTimeout_NegativeInput verifies that a
+// negative connectTimeout is also replaced with defaultConnectTimeout.
+func TestNewHTTPConnection_DefaultConnectTimeout_NegativeInput(t *testing.T) {
+	srv := newMinimalTestServer(t)
+	defer srv.Close()
+
+	conn, err := NewHTTPConnection(context.Background(), "test", srv.URL,
+		map[string]string{"Authorization": "test"}, nil, "", 0, -1*time.Second)
+	require.NoError(t, err)
+	require.NotNil(t, conn)
+	defer conn.Close()
+
+	assert.Equal(t, defaultConnectTimeout, conn.connectTimeout,
+		"negative connectTimeout should be replaced with defaultConnectTimeout")
+}
+
+// TestNewHTTPConnection_DefaultConnectTimeout_CustomValue verifies that a
+// positive connectTimeout is stored as-is without being replaced.
+func TestNewHTTPConnection_DefaultConnectTimeout_CustomValue(t *testing.T) {
+	srv := newMinimalTestServer(t)
+	defer srv.Close()
+
+	custom := 10 * time.Second
+	conn, err := NewHTTPConnection(context.Background(), "test", srv.URL,
+		map[string]string{"Authorization": "test"}, nil, "", 0, custom)
+	require.NoError(t, err)
+	require.NotNil(t, conn)
+	defer conn.Close()
+
+	assert.Equal(t, custom, conn.connectTimeout,
+		"a positive connectTimeout should be stored unchanged")
+}
+
+// TestDefaultConnectTimeout_Value guards against the constant value drifting
+// away from config.DefaultConnectTimeout (30 s) unintentionally.
+func TestDefaultConnectTimeout_Value(t *testing.T) {
+	assert.Equal(t, 30*time.Second, defaultConnectTimeout,
+		"defaultConnectTimeout must remain 30 s to stay in sync with config.DefaultConnectTimeout")
+}