[test-improver] Improve tests for version package (#4140)

## Test Improvements: `version_test.go`

## File Analyzed

- **Test File**: `internal/version/version_test.go`
- **Package**: `internal/version`
- **Lines of Code**: 85 → 144 (+59 lines)

## Improvements Made

### 1. Increased Coverage
- ✅ Added `TestBuildVersionString` with 8 subtests covering all
explicit-parameter branches of `BuildVersionString`
- **Previous Coverage**: 12% (only `Set` and `Get` were tested;
`BuildVersionString` had 0%)
- **New Coverage**: 72%
- **Improvement**: +60%

### 2. Better Testing Patterns
- ✅ Used `t.Run` subtests for each logical scenario in
`TestBuildVersionString`
- ✅ Used `assert.Equal` for deterministic cases (all three parameters
supplied)
- ✅ Used `strings.HasPrefix` / `strings.HasSuffix` / `assert.Contains`
for partially-deterministic cases where the `debug.ReadBuildInfo()`
fallback may or may not append extra fields
- ✅ Added `require.GreaterOrEqual` to guard against panics when
splitting output into parts

### 3. Branches Covered

| Branch | Covered? | Notes |
|---|---|---|
| `mainVersion != ""` → use mainVersion | ✅ | Deterministic |
| `mainVersion == ""` → use `"dev"` | ✅ | Deterministic |
| `gitCommit != ""` → use `"commit: <gitCommit>"` | ✅ | Deterministic |
| `gitCommit == ""` → fall back to `debug.ReadBuildInfo()` vcs.revision
| ✅ (entry)| Inner body not coverable in unit tests (no embedded VCS
metadata) |
| `buildDate != ""` → use `"built: <buildDate>"` | ✅ | Deterministic |
| `buildDate == ""` → fall back to `debug.ReadBuildInfo()` vcs.time | ✅
(entry) | Inner body not coverable in unit tests |
| explicit `gitCommit` is not truncated (truncation only in fallback) |
✅ | Documents the truncation behaviour contract |

The remaining uncovered lines (~32% of `BuildVersionString`) are the
loop bodies that match `vcs.revision`/`vcs.time` settings inside
`debug.ReadBuildInfo()`; these are only populated when the binary is
built with embedded VCS metadata via `go build -ldflags` and cannot be
exercised in unit tests.

## Test Execution

All tests pass:

```
=== RUN   TestBuildVersionString
=== RUN   TestBuildVersionString/all_fields_provided
=== RUN   TestBuildVersionString/empty_mainVersion_uses_dev_prefix
=== RUN   TestBuildVersionString/mainVersion_and_gitCommit_without_buildDate
=== RUN   TestBuildVersionString/mainVersion_and_buildDate_without_gitCommit
=== RUN   TestBuildVersionString/only_mainVersion
=== RUN   TestBuildVersionString/all_empty_uses_dev
=== RUN   TestBuildVersionString/result_is_comma-separated
=== RUN   TestBuildVersionString/explicit_gitCommit_is_not_truncated
--- PASS: TestBuildVersionString (0.00s)
PASS
coverage: 72.0% of statements
ok  	github.com/github/gh-aw-mcpg/internal/version	0.004s
```

## Why These Changes?

`BuildVersionString` constructs the version string displayed in health
checks, `--version` output, and MCP client metadata. It had zero test
coverage despite having six distinct branches. The new tests document
the function's contract for all explicitly-supplied-parameter paths and
confirm stability across builds where `debug.ReadBuildInfo()` may or may
not provide VCS metadata.

---
*Generated by Test Improver Workflow*
*Focuses on better patterns, increased coverage, and more stable tests*




> Generated by [Test
Improver](https://github.com/github/gh-aw-mcpg/actions/runs/24628026201/agentic_workflow)
· ● 972.4K ·
[◷](https://github.com/search?q=repo%3Agithub%2Fgh-aw-mcpg+%22gh-aw-workflow-id%3A+test-improver%22&type=pullrequests)

<!-- gh-aw-agentic-workflow: Test Improver, engine: copilot, model:
auto, id: 24628026201, workflow_id: test-improver, run:
https://github.com/github/gh-aw-mcpg/actions/runs/24628026201 -->

<!-- gh-aw-workflow-id: test-improver -->

Author: lpcox

internal/version/version_test.go

@@ -1,9 +1,11 @@
 package version
 
 import (
+	"strings"
 	"testing"
 
 	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
 )
 
 func TestSet(t *testing.T) {
@@ -57,6 +59,63 @@ func TestSet(t *testing.T) {
 	}
 }
 
+func TestBuildVersionString(t *testing.T) {
+	t.Run("all fields provided", func(t *testing.T) {
+		got := BuildVersionString("v1.2.3", "abc1234", "2024-01-01")
+		assert.Equal(t, "v1.2.3, commit: abc1234, built: 2024-01-01", got)
+	})
+
+	t.Run("empty mainVersion uses dev prefix", func(t *testing.T) {
+		got := BuildVersionString("", "abc1234", "2024-01-01")
+		assert.Equal(t, "dev, commit: abc1234, built: 2024-01-01", got)
+	})
+
+	t.Run("mainVersion and gitCommit without buildDate", func(t *testing.T) {
+		got := BuildVersionString("v1.2.3", "abc1234", "")
+		// buildDate is empty so build info fallback may or may not add a date
+		assert.True(t, strings.HasPrefix(got, "v1.2.3, commit: abc1234"),
+			"result should start with version and commit: got %q", got)
+	})
+
+	t.Run("mainVersion and buildDate without gitCommit", func(t *testing.T) {
+		got := BuildVersionString("v1.2.3", "", "2024-01-01")
+		// gitCommit is empty so build info fallback may or may not add a commit
+		assert.True(t, strings.HasPrefix(got, "v1.2.3"),
+			"result should start with version: got %q", got)
+		assert.True(t, strings.HasSuffix(got, "built: 2024-01-01"),
+			"result should end with built date: got %q", got)
+	})
+
+	t.Run("only mainVersion", func(t *testing.T) {
+		got := BuildVersionString("v2.0.0", "", "")
+		// No explicit commit or date; build info fallback may add them
+		assert.True(t, strings.HasPrefix(got, "v2.0.0"),
+			"result should start with mainVersion: got %q", got)
+	})
+
+	t.Run("all empty uses dev", func(t *testing.T) {
+		got := BuildVersionString("", "", "")
+		assert.True(t, strings.HasPrefix(got, "dev"),
+			"result should start with 'dev' when mainVersion is empty: got %q", got)
+	})
+
+	t.Run("result is comma-separated", func(t *testing.T) {
+		got := BuildVersionString("v1.0.0", "deadbeef", "2025-06-01")
+		parts := strings.Split(got, ", ")
+		require.GreaterOrEqual(t, len(parts), 3, "should have at least 3 comma-separated parts")
+		assert.Equal(t, "v1.0.0", parts[0])
+		assert.Equal(t, "commit: deadbeef", parts[1])
+		assert.Equal(t, "built: 2025-06-01", parts[2])
+	})
+
+	t.Run("explicit gitCommit is not truncated", func(t *testing.T) {
+		longHash := "abcdef1234567890"
+		got := BuildVersionString("v1.0.0", longHash, "2024-01-01")
+		// When gitCommit is explicitly provided it is used as-is (no truncation)
+		assert.Contains(t, got, "commit: "+longHash)
+	})
+}
+
 func TestGet(t *testing.T) {
 	t.Run("returns default version", func(t *testing.T) {
 		original := gatewayVersion