C#: Move handling of callables into shared control flow library

hvitved · hvitved · commit aa78c5969a06 · 2026-04-22T13:17:35.000+02:00
diff --git a/csharp/ql/lib/semmle/code/csharp/controlflow/ControlFlowGraph.qll b/csharp/ql/lib/semmle/code/csharp/controlflow/ControlFlowGraph.qll
@@ -25,7 +25,7 @@ private module Ast implements AstSig<Location> {
 
   class AstNode = ControlFlowElementOrCallable;
 
-  private predicate skipControlFlow(AstNode e) {
+  additional predicate skipControlFlow(AstNode e) {
     e instanceof TypeAccess and
     not e instanceof TypeAccessPatternExpr
     or
@@ -82,13 +82,8 @@ private module Ast implements AstSig<Location> {
 
   AstNode callableGetBody(Callable c) {
     not skipControlFlow(result) and
-    (
-      result = c.getBody() or
-      result = c.(Constructor).getObjectInitializerCall() or
-      result = c.(Constructor).getInitializer() or
-      c.(ObjectInitMethod).initializes(result) or
-      Initializers::staticMemberInitializer(c, result)
-    )
+    result = c.getBody() and
+    not c instanceof Constructor // handled in `callableGetBodyPart`
   }
 
   class Stmt = CS::Stmt;
@@ -222,10 +217,21 @@ private module Ast implements AstSig<Location> {
  * Unlike the standard `Compilation` class, this class also supports buildless
  * extraction.
  */
-private newtype CompilationExt =
+private newtype TCompilationExt =
   TCompilation(Compilation c) { not extractionIsStandalone() } or
   TBuildless() { extractionIsStandalone() }
 
+private class CompilationExt extends TCompilationExt {
+  string toString() {
+    exists(Compilation c |
+      this = TCompilation(c) and
+      result = c.toString()
+    )
+    or
+    this = TBuildless() and result = "buildless compilation"
+  }
+}
+
 /** Gets the compilation that source file `f` belongs to. */
 private CompilationExt getCompilation(File f) {
   exists(Compilation c |
@@ -274,12 +280,13 @@ private module Initializers {
   /**
    * Gets the `i`th static member initializer expression for static constructor `staticCtor`.
    */
-  Expr initializedStaticMemberOrder(Constructor staticCtor, int i) {
+  Expr initializedStaticMemberOrder(Constructor staticCtor, CompilationExt comp, int i) {
     result =
       rank[i + 1](Expr init, Location l, string filepath, int startline, int startcolumn |
         staticMemberInitializer(staticCtor, init) and
         l = init.getLocation() and
-        l.hasLocationInfo(filepath, startline, startcolumn, _, _)
+        l.hasLocationInfo(filepath, startline, startcolumn, _, _) and
+        getCompilation(l.getFile()) = comp
       |
         init order by startline, startcolumn, filepath
       )
@@ -301,17 +308,6 @@ private module Initializers {
         ae0 order by startline, startcolumn, filepath
       )
   }
-
-  /**
-   * Gets the last member initializer expression for object initializer method `obinit`
-   * in compilation `comp`.
-   */
-  AssignExpr lastInitializer(ObjectInitMethod obinit, CompilationExt comp) {
-    exists(int i |
-      result = initializedInstanceMemberOrder(obinit, comp, i) and
-      not exists(initializedInstanceMemberOrder(obinit, comp, i + 1))
-    )
-  }
 }
 
 private module Exceptions {
@@ -424,6 +420,54 @@ private module Input implements InputSig1, InputSig2 {
     l = TLblGoto(n.(LabelStmt).getLabel())
   }
 
+  pragma[noinline]
+  private MethodCall getObjectInitializerCall(Constructor ctor, CompilationExt comp) {
+    result = ctor.getObjectInitializerCall() and
+    comp = getCompilation(result.getFile())
+  }
+
+  pragma[noinline]
+  private ConstructorInitializer getInitializer(Constructor ctor, CompilationExt comp) {
+    result = ctor.getInitializer() and
+    comp = getCompilation(result.getFile())
+  }
+
+  pragma[noinline]
+  private Ast::AstNode getBody(Constructor ctor, CompilationExt comp) {
+    result = ctor.getBody() and
+    comp = getCompilation(result.getFile())
+  }
+
+  class CallableBodyPartContext = CompilationExt;
+
+  Ast::AstNode callableGetBodyPart(Callable c, CallableBodyPartContext ctx, int index) {
+    not Ast::skipControlFlow(result) and
+    (
+      result = Initializers::initializedInstanceMemberOrder(c, ctx, index)
+      or
+      result =
+        rank[index + 1](Ast::AstNode child, int i, int j |
+          i = 0 and
+          child = Initializers::initializedStaticMemberOrder(c, ctx, j)
+          or
+          i = 1 and
+          j = 0 and
+          child = getObjectInitializerCall(c, ctx)
+          or
+          i = 2 and
+          (
+            j = 0 and
+            child = getInitializer(c, ctx)
+            or
+            j = 1 and
+            child = getBody(c, ctx)
+          )
+        |
+          child order by i, j
+        )
+    )
+  }
+
   private Expr getQualifier(QualifiableExpr qe) {
     result = qe.getQualifier() or
     result = qe.(ExtensionMethodCall).getArgument(0)
@@ -474,80 +518,7 @@ private module Input implements InputSig1, InputSig2 {
     )
   }
 
-  pragma[noinline]
-  private MethodCall getObjectInitializerCall(Constructor ctor, CompilationExt comp) {
-    result = ctor.getObjectInitializerCall() and
-    comp = getCompilation(result.getFile())
-  }
-
-  pragma[noinline]
-  private ConstructorInitializer getInitializer(Constructor ctor, CompilationExt comp) {
-    result = ctor.getInitializer() and
-    comp = getCompilation(result.getFile())
-  }
-
-  pragma[noinline]
-  private Ast::AstNode getBody(Constructor ctor, CompilationExt comp) {
-    result = ctor.getBody() and
-    comp = getCompilation(result.getFile())
-  }
-
   predicate step(PreControlFlowNode n1, PreControlFlowNode n2) {
-    exists(Constructor ctor |
-      n1.(EntryNodeImpl).getEnclosingCallable() = ctor and
-      if Initializers::staticMemberInitializer(ctor, _)
-      then n2.isBefore(Initializers::initializedStaticMemberOrder(ctor, 0))
-      else
-        if exists(ctor.getObjectInitializerCall())
-        then n2.isBefore(ctor.getObjectInitializerCall())
-        else
-          if exists(ctor.getInitializer())
-          then n2.isBefore(ctor.getInitializer())
-          else n2.isBefore(ctor.getBody())
-      or
-      exists(int i | n1.isAfter(Initializers::initializedStaticMemberOrder(ctor, i)) |
-        n2.isBefore(Initializers::initializedStaticMemberOrder(ctor, i + 1))
-        or
-        not exists(Initializers::initializedStaticMemberOrder(ctor, i + 1)) and
-        n2.isBefore(ctor.getBody())
-      )
-      or
-      exists(CompilationExt comp |
-        n1.isAfter(getObjectInitializerCall(ctor, comp)) and
-        if exists(getInitializer(ctor, comp))
-        then n2.isBefore(getInitializer(ctor, comp))
-        else
-          // This is only relevant in the context of compilation errors, since
-          // normally the existence of an object initializer call implies the
-          // existence of an initializer.
-          if exists(getBody(ctor, comp))
-          then n2.isBefore(getBody(ctor, comp))
-          else n2.(NormalExitNodeImpl).getEnclosingCallable() = ctor
-        or
-        n1.isAfter(getInitializer(ctor, comp)) and
-        if exists(getBody(ctor, comp))
-        then n2.isBefore(getBody(ctor, comp))
-        else n2.(NormalExitNodeImpl).getEnclosingCallable() = ctor
-      )
-      or
-      n1.isAfter(ctor.getBody()) and
-      n2.(NormalExitNodeImpl).getEnclosingCallable() = ctor
-    )
-    or
-    exists(ObjectInitMethod obinit |
-      n1.(EntryNodeImpl).getEnclosingCallable() = obinit and
-      n2.isBefore(Initializers::initializedInstanceMemberOrder(obinit, _, 0))
-      or
-      exists(CompilationExt comp, int i |
-        // Flow from one member initializer to the next
-        n1.isAfter(Initializers::initializedInstanceMemberOrder(obinit, comp, i)) and
-        n2.isBefore(Initializers::initializedInstanceMemberOrder(obinit, comp, i + 1))
-      )
-      or
-      n1.isAfter(Initializers::lastInitializer(obinit, _)) and
-      n2.(NormalExitNodeImpl).getEnclosingCallable() = obinit
-    )
-    or
     exists(QualifiableExpr qe | qe.isConditional() |
       n1.isBefore(qe) and n2.isBefore(getQualifier(qe))
       or
diff --git a/shared/controlflow/codeql/controlflow/ControlFlowGraph.qll b/shared/controlflow/codeql/controlflow/ControlFlowGraph.qll
@@ -38,16 +38,16 @@ signature module AstSig<LocationSig Location> {
     Location getLocation();
   }
 
-  /** Gets the child of this AST node at the specified index. */
+  /** Gets the child of AST node `n` at the specified index. */
   AstNode getChild(AstNode n, int index);
 
-  /** Gets the immediately enclosing callable that contains this node. */
+  /** Gets the immediately enclosing callable that contains `node`. */
   Callable getEnclosingCallable(AstNode node);
 
   /** A callable, for example a function, method, constructor, or top-level script. */
   class Callable extends AstNode;
 
-  /** Gets the body of this callable, if any. */
+  /** Gets the body of callable `c`, if any. */
   AstNode callableGetBody(Callable c);
 
   /** A statement. */
@@ -454,6 +454,26 @@ module Make0<LocationSig Location, AstSig<Location> Ast> {
     default predicate successorValueImplies(ConditionalSuccessor t1, ConditionalSuccessor t2) {
       none()
     }
+
+    /**
+     * An additional context needed to identify the body parts of a callable.
+     *
+     * When not used, instantiate with the `Void` type.
+     */
+    class CallableBodyPartContext {
+      /** Gets a textual representation of this context. */
+      string toString();
+    }
+
+    /**
+     * Gets the `index`th part of the body of `c` in context `ctx`.
+     *
+     * `callableGetBodyPart(c, _, _)` and `callableGetBody(c)` must never both hold
+     * for a given callable `c`.
+     */
+    default AstNode callableGetBodyPart(Callable c, CallableBodyPartContext ctx, int index) {
+      none()
+    }
   }
 
   /**
@@ -661,6 +681,34 @@ module Make0<LocationSig Location, AstSig<Location> Ast> {
      *   not step to it, since "after" represents normal termination).
      */
 
+    private predicate isCallableBodyPart(Callable c, AstNode n) {
+      n = callableGetBody(c) or n = Input1::callableGetBodyPart(c, _, _)
+    }
+
+    private AstNode getRankedBodyPart(Callable c, Input1::CallableBodyPartContext ctx, int rnk) {
+      result =
+        rank[rnk](AstNode child, int ix |
+          child = Input1::callableGetBodyPart(c, ctx, ix)
+        |
+          child order by ix
+        )
+    }
+
+    private AstNode getBodyEntry(Callable c) {
+      result = callableGetBody(c)
+      or
+      result = getRankedBodyPart(c, _, 1)
+    }
+
+    private AstNode getBodyExit(Callable c) {
+      result = callableGetBody(c)
+      or
+      exists(Input1::CallableBodyPartContext ctx, int last |
+        result = getRankedBodyPart(c, ctx, last) and
+        not exists(getRankedBodyPart(c, ctx, last + 1))
+      )
+    }
+
     cached
     private newtype TNode =
       TBeforeNode(AstNode n) { Input1::cfgCachedStageRef() and exists(getEnclosingCallable(n)) } or
@@ -677,9 +725,9 @@ module Make0<LocationSig Location, AstSig<Location> Ast> {
       TAdditionalNode(AstNode n, string tag) {
         additionalNode(n, tag, _) and exists(getEnclosingCallable(n))
       } or
-      TEntryNode(Callable c) { exists(callableGetBody(c)) } or
-      TAnnotatedExitNode(Callable c, Boolean normal) { exists(callableGetBody(c)) } or
-      TExitNode(Callable c) { exists(callableGetBody(c)) }
+      TEntryNode(Callable c) { isCallableBodyPart(c, _) } or
+      TAnnotatedExitNode(Callable c, Boolean normal) { isCallableBodyPart(c, _) } or
+      TExitNode(Callable c) { isCallableBodyPart(c, _) }
 
     private class NodeImpl extends TNode {
       /**
@@ -895,7 +943,7 @@ module Make0<LocationSig Location, AstSig<Location> Ast> {
     }
 
     /** The `PreControlFlowNode` at the entry point of a callable. */
-    final class EntryNodeImpl extends NodeImpl, TEntryNode {
+    final private class EntryNodeImpl extends NodeImpl, TEntryNode {
       private Callable c;
 
       EntryNodeImpl() { this = TEntryNode(c) }
@@ -1097,7 +1145,7 @@ module Make0<LocationSig Location, AstSig<Location> Ast> {
       private predicate endAbruptCompletion(AstNode ast, PreControlFlowNode n, AbruptCompletion c) {
         Input2::endAbruptCompletion(ast, n, c)
         or
-        exists(Callable callable | ast = callableGetBody(callable) |
+        exists(Callable callable | isCallableBodyPart(callable, ast) |
           c.getSuccessorType() instanceof ReturnSuccessor and
           n.(NormalExitNodeImpl).getEnclosingCallable() = callable
           or
@@ -1255,22 +1303,15 @@ module Make0<LocationSig Location, AstSig<Location> Ast> {
         )
       }
 
-      private predicate hasSpecificCallableSteps(Callable c) {
-        exists(EntryNodeImpl entry | entry.getEnclosingCallable() = c and Input2::step(entry, _))
-      }
-
       /** Holds if there is a local non-abrupt step from `n1` to `n2`. */
       private predicate explicitStep(PreControlFlowNode n1, PreControlFlowNode n2) {
         Input2::step(n1, n2)
         or
         exists(Callable c |
-          // Allow language-specific overrides for the default entry and exit edges.
-          not hasSpecificCallableSteps(c) and
           n1.(EntryNodeImpl).getEnclosingCallable() = c and
-          n2.isBefore(callableGetBody(c))
+          n2.isBefore(getBodyEntry(c))
           or
-          not hasSpecificCallableSteps(c) and
-          n1.isAfter(callableGetBody(c)) and
+          n1.isAfter(getBodyExit(c)) and
           n2.(NormalExitNodeImpl).getEnclosingCallable() = c
           or
           n1.(AnnotatedExitNodeImpl).getEnclosingCallable() = c and
@@ -1650,9 +1691,17 @@ module Make0<LocationSig Location, AstSig<Location> Ast> {
           n1.isBefore(ast) and
           n2.isBefore(getRankedChild(ast, 1))
           or
-          exists(int i |
-            n1.isAfter(getRankedChild(ast, i)) and
-            n2.isBefore(getRankedChild(ast, i + 1))
+          exists(int i, AstNode prev, AstNode next |
+            n1.isAfter(prev) and
+            n2.isBefore(next)
+          |
+            prev = getRankedChild(ast, i) and
+            next = getRankedChild(ast, i + 1)
+            or
+            exists(Input1::CallableBodyPartContext ctx |
+              prev = getRankedBodyPart(ast, ctx, i) and
+              next = getRankedBodyPart(ast, ctx, i + 1)
+            )
           )
           or
           (
@@ -2128,6 +2177,14 @@ module Make0<LocationSig Location, AstSig<Location> Ast> {
           query predicate selfLoop(ControlFlowNode node, SuccessorType t) {
             node.getASuccessor(t) = node
           }
+
+          /**
+           * Holds if `c` is included in both `callableGetBody` and `callableGetBodyPart`.
+           */
+          query predicate bodyPartOverlap(Callable c) {
+            exists(callableGetBody(c)) and
+            exists(Input1::callableGetBodyPart(c, _, _))
+          }
         }
       }
     }
