Address comments

Author: Daverlo

lib/actions-util.js

@@ -112,6 +112,16 @@ test("computeAutomationID()", async (t) => {
     actualAutomationID,
     ".github/workflows/codeql-analysis.yml:analyze/number:/object:/"
   );
+
+  // check undefined environment
+  actualAutomationID = actionsutil.computeAutomationID(
+    ".github/workflows/codeql-analysis.yml:analyze",
+    undefined
+  );
+  t.deepEqual(
+    actualAutomationID,
+    ".github/workflows/codeql-analysis.yml:analyze/"
+  );
 });
 
 test("prepareEnvironment() when a local run", (t) => {

lib/actions-util.js.map

@@ -433,13 +433,13 @@ export async function getAutomationID(): Promise<string> {
 }
 
 export function computeAutomationID(
-  analysis_key: string | undefined,
+  analysis_key: string,
   environment: string | undefined
 ): string {
   let automationID = `${analysis_key}/`;
 
   // the id has to be deterministic so we sort the fields
-  if (environment !== undefined && environment !== "null") {
+  if (environment) {
     const environmentObject = JSON.parse(environment);
     for (const entry of Object.entries(environmentObject).sort()) {
       if (typeof entry[1] === "string") {

lib/actions-util.test.js

@@ -67,7 +67,7 @@ export function populateRunAutomationDetails(
 
 function getAutomationID(
   category: string | undefined,
-  analysis_key: string | undefined,
+  analysis_key: string,
   environment: string | undefined
 ): string {
   if (category !== undefined) {